feat(live datasouces): moved from Observable to Subject

public/app/features/panel/metrics_panel_ctrl.ts

@@ -26,8 +26,7 @@ class MetricsPanelCtrl extends PanelCtrl {
   timeInfo: any;
   timeInfo: any;
   skipDataOnInit: boolean;
   skipDataOnInit: boolean;
   datasources: any[];
   datasources: any[];
-  dataSubscription: any;
-  dataHandler: any;
+  dataSubject: any;
 
 
   constructor($scope, $injector) {
   constructor($scope, $injector) {
     super($scope, $injector);
     super($scope, $injector);
@@ -168,7 +167,12 @@ class MetricsPanelCtrl extends PanelCtrl {
       return this.$q.when([]);
       return this.$q.when([]);
     }
     }
 
 
+    if (this.dataSubject) {
+      return this.$q.when([]);
+    }
+
     var metricsQuery = {
     var metricsQuery = {
+      panelId: this.panel.id,
       range: this.range,
       range: this.range,
       rangeRaw: this.rangeRaw,
       rangeRaw: this.rangeRaw,
       interval: this.interval,
       interval: this.interval,
@@ -184,9 +188,9 @@ class MetricsPanelCtrl extends PanelCtrl {
       return datasource.query(metricsQuery).then(results => {
       return datasource.query(metricsQuery).then(results => {
         this.setTimeQueryEnd();
         this.setTimeQueryEnd();
 
 
-        // check for if data source returns observable
+        // check for if data source returns subject
         if (results && results.subscribe) {
         if (results && results.subscribe) {
-          this.handleObservable(results);
+          this.handleDataSubject(results);
           return {data: []};
           return {data: []};
         }
         }
 
 
@@ -194,16 +198,27 @@ class MetricsPanelCtrl extends PanelCtrl {
           this.panel.snapshotData = results;
           this.panel.snapshotData = results;
         }
         }
 
 
-        return results;
+        return this.dataHandler(results);
       });
       });
     } catch (err) {
     } catch (err) {
       return this.$q.reject(err);
       return this.$q.reject(err);
     }
     }
   }
   }
 
 
-  handleObservable(observable) {
-    this.dataSubscription = observable.subscribe({
+  dataHandler(data) {
+    return data;
+  }
+
+  handleDataSubject(subject) {
+    // if we already have a connection
+    if (this.dataSubject) {
+      return;
+    }
+
+    this.dataSubject = subject;
+    this.dataSubject.subscribe({
       next: (data) => {
       next: (data) => {
+        console.log('dataSubject next!');
         if (data.range) {
         if (data.range) {
           this.range = data.range;
           this.range = data.range;
         }
         }

public/app/plugins/panel/graph/module.ts

@@ -140,9 +140,7 @@ class GraphCtrl extends MetricsPanelCtrl {
   refreshData(datasource) {
   refreshData(datasource) {
     this.annotationsPromise = this.annotationsSrv.getAnnotations(this.dashboard);
     this.annotationsPromise = this.annotationsSrv.getAnnotations(this.dashboard);
 
 
-    return this.issueQueries(datasource)
-    .then(res => this.dataHandler(res))
-    .catch(err => {
+    return this.issueQueries(datasource).catch(err => {
       this.seriesList = [];
       this.seriesList = [];
       this.render([]);
       this.render([]);
       throw err;
       throw err;