Commit 1e5f2f56 by Erik Sundell

improve component performance

parent 86a39183
......@@ -40,11 +40,8 @@ export class StackdriverPicker extends React.Component<Props, State> {
}
shouldComponentUpdate(nextProps: Props) {
return (
nextProps.selected !== this.props.selected ||
!_.isEqual(nextProps.options, this.props.options) ||
!_.isEqual(nextProps.templateVariables, this.props.templateVariables)
);
const nextOptions = this.buildOptions(nextProps);
return nextProps.selected !== this.props.selected || !_.isEqual(nextOptions, this.state.options);
}
buildOptions({ templateVariables = [], groupName = '', options }) {
......@@ -89,9 +86,7 @@ export class StackdriverPicker extends React.Component<Props, State> {
backspaceRemovesValue={false}
onChange={item => onChange(item.value)}
options={options}
autoFocus={false}
isSearchable={searchable}
openMenuOnFocus={true}
maxMenuHeight={500}
placeholder={placeholder}
noOptionsMessage={() => 'No options found'}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment