Commit 204682e9 by Marcus Andersson Committed by GitHub

Fix: making select to return empty list when no values are selected in multivalue mode.

* Fixed error in storybook when remving selections.

* moved fix to select base instead of in story.

* updated to check for null or undefined.
parent 12f1af29
import React from 'react';
import React, { useCallback } from 'react';
import { SelectableValue, deprecationWarning } from '@grafana/data';
// @ts-ignore
import { default as ReactSelect } from '@torkelo/react-select';
......@@ -178,6 +178,15 @@ export function SelectBase<T>({
}: SelectBaseProps<T>) {
const theme = useTheme();
const styles = getSelectStyles(theme);
const onChangeWithEmpty = useCallback(
(value: SelectValue<T>) => {
if (isMulti && (value === undefined || value === null)) {
return onChange([]);
}
onChange(value);
},
[isMulti]
);
let ReactSelectComponent: ReactSelect | Creatable = ReactSelect;
const creatableProps: any = {};
let asyncSelectProps: any = {};
......@@ -229,7 +238,7 @@ export function SelectBase<T>({
onMenuClose: onCloseMenu,
tabSelectsValue,
options,
onChange,
onChange: onChangeWithEmpty,
onBlur,
onKeyDown,
menuShouldScrollIntoView: false,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment