chore: wip: Replace brace with ace-builds to get latest version of ace

package.json

@@ -151,13 +151,13 @@
   "dependencies": {
   "dependencies": {
     "@babel/polyfill": "^7.0.0",
     "@babel/polyfill": "^7.0.0",
     "@torkelo/react-select": "2.1.1",
     "@torkelo/react-select": "2.1.1",
+    "ace-builds": "^1.4.2",
     "angular": "1.6.6",
     "angular": "1.6.6",
     "angular-bindonce": "0.3.1",
     "angular-bindonce": "0.3.1",
     "angular-native-dragdrop": "1.2.2",
     "angular-native-dragdrop": "1.2.2",
     "angular-route": "1.6.6",
     "angular-route": "1.6.6",
     "angular-sanitize": "1.6.6",
     "angular-sanitize": "1.6.6",
     "baron": "^3.0.3",
     "baron": "^3.0.3",
-    "brace": "^0.10.0",
     "classnames": "^2.2.6",
     "classnames": "^2.2.6",
     "clipboard": "^1.7.1",
     "clipboard": "^1.7.1",
     "d3": "^4.11.0",
     "d3": "^4.11.0",

public/app/core/components/code_editor/code_editor.ts

@@ -30,20 +30,20 @@
 
 
 import coreModule from 'app/core/core_module';
 import coreModule from 'app/core/core_module';
 import config from 'app/core/config';
 import config from 'app/core/config';
-import ace from 'brace';
+import * as ace from 'ace-builds/src-noconflict/ace';
 import './theme-grafana-dark';
 import './theme-grafana-dark';
-import 'brace/ext/language_tools';
-import 'brace/theme/textmate';
-import 'brace/mode/text';
-import 'brace/snippets/text';
-import 'brace/mode/sql';
-import 'brace/snippets/sql';
-import 'brace/mode/sqlserver';
-import 'brace/snippets/sqlserver';
-import 'brace/mode/markdown';
-import 'brace/snippets/markdown';
-import 'brace/mode/json';
-import 'brace/snippets/json';
+import 'ace-builds/src-noconflict/ext-language_tools';
+import 'ace-builds/src-noconflict/theme-textmate';
+import 'ace-builds/src-noconflict/mode-text';
+import 'ace-builds/src-noconflict/snippets/text';
+import 'ace-builds/src-noconflict/mode-sql';
+import 'ace-builds/src-noconflict/snippets/sql';
+import 'ace-builds/src-noconflict/mode-sqlserver';
+import 'ace-builds/src-noconflict/snippets/sqlserver';
+import 'ace-builds/src-noconflict/mode-markdown';
+import 'ace-builds/src-noconflict/snippets/markdown';
+import 'ace-builds/src-noconflict/mode-json';
+import 'ace-builds/src-noconflict/snippets/json';
 
 
 const DEFAULT_THEME_DARK = 'ace/theme/grafana-dark';
 const DEFAULT_THEME_DARK = 'ace/theme/grafana-dark';
 const DEFAULT_THEME_LIGHT = 'ace/theme/textmate';
 const DEFAULT_THEME_LIGHT = 'ace/theme/textmate';
@@ -143,7 +143,7 @@ function link(scope, elem, attrs) {
   });
   });
 
 
   function setLangMode(lang) {
   function setLangMode(lang) {
-    ace.acequire('ace/ext/language_tools');
+    // ace.acequire('ace/ext/language_tools'); // TODO: Do we need this?
     codeEditor.setOptions({
     codeEditor.setOptions({
       enableBasicAutocompletion: true,
       enableBasicAutocompletion: true,
       enableLiveAutocompletion: true,
       enableLiveAutocompletion: true,

yarn.lock

@@ -2265,6 +2265,11 @@ accepts@~1.3.4, accepts@~1.3.5:
     mime-types "~2.1.18"
     mime-types "~2.1.18"
     negotiator "0.6.1"
     negotiator "0.6.1"
 
 
+ace-builds@^1.4.2:
+  version "1.4.2"
+  resolved "https://registry.yarnpkg.com/ace-builds/-/ace-builds-1.4.2.tgz#6afc2e43a7b5effdc44d8407436112852568e80d"
+  integrity sha512-M1JtZctO2Zg+1qeGUFZXtYKsyaRptqQtqpVzlj80I0NzGW9MF3um0DBuizIvQlrPYUlTdm+wcOPZpZoerkxQdA==
+
 acorn-dynamic-import@^3.0.0:
 acorn-dynamic-import@^3.0.0:
   version "3.0.0"
   version "3.0.0"
   resolved "https://registry.yarnpkg.com/acorn-dynamic-import/-/acorn-dynamic-import-3.0.0.tgz#901ceee4c7faaef7e07ad2a47e890675da50a278"
   resolved "https://registry.yarnpkg.com/acorn-dynamic-import/-/acorn-dynamic-import-3.0.0.tgz#901ceee4c7faaef7e07ad2a47e890675da50a278"
@@ -4125,13 +4130,6 @@ brace-expansion@^1.0.0, brace-expansion@^1.1.7:
     balanced-match "^1.0.0"
     balanced-match "^1.0.0"
     concat-map "0.0.1"
     concat-map "0.0.1"
 
 
-brace@^0.10.0:
-  version "0.10.0"
-  resolved "https://registry.yarnpkg.com/brace/-/brace-0.10.0.tgz#edef4eb9b0928ba1ee5f717ffc157749a6dd5d76"
-  integrity sha1-7e9OubCSi6HuX3F//BV3SabdXXY=
-  dependencies:
-    w3c-blob "0.0.1"
-
 braces@^1.8.2:
 braces@^1.8.2:
   version "1.8.5"
   version "1.8.5"
   resolved "https://registry.yarnpkg.com/braces/-/braces-1.8.5.tgz#ba77962e12dff969d6b76711e914b737857bf6a7"
   resolved "https://registry.yarnpkg.com/braces/-/braces-1.8.5.tgz#ba77962e12dff969d6b76711e914b737857bf6a7"
@@ -17283,11 +17281,6 @@ vm-browserify@0.0.4:
   dependencies:
   dependencies:
     indexof "0.0.1"
     indexof "0.0.1"
 
 
-w3c-blob@0.0.1:
-  version "0.0.1"
-  resolved "https://registry.yarnpkg.com/w3c-blob/-/w3c-blob-0.0.1.tgz#b0cd352a1a50f515563420ffd5861f950f1d85b8"
-  integrity sha1-sM01KhpQ9RVWNCD/1YYflQ8dhbg=
-
 w3c-hr-time@^1.0.1:
 w3c-hr-time@^1.0.1:
   version "1.0.1"
   version "1.0.1"
   resolved "https://registry.yarnpkg.com/w3c-hr-time/-/w3c-hr-time-1.0.1.tgz#82ac2bff63d950ea9e3189a58a65625fedf19045"
   resolved "https://registry.yarnpkg.com/w3c-hr-time/-/w3c-hr-time-1.0.1.tgz#82ac2bff63d950ea9e3189a58a65625fedf19045"