Move error log in social.go inside err != nil (#27804)

334cb41a · Bill Oley · GitHub · 69ba7bff · 334cb41a
Commit 334cb41a authored Sep 25, 2020 by Bill Oley Committed by GitHub Sep 25, 2020
Show whitespace changes
Inline Side-by-side

Showing with 1 additions and 1 deletions

pkg/login/social/social.go
+1 -1

No files found.
--- a/pkg/login/social/social.go
+++ b/pkg/login/social/social.go
@@ -258,8 +258,8 @@ func GetOAuthHttpClient(name string) (*http.Client, error) {

 	if info.TlsClientCert != "" || info.TlsClientKey != "" {
 		cert, err := tls.LoadX509KeyPair(info.TlsClientCert, info.TlsClientKey)
-		logger.Error("Failed to setup TlsClientCert", "oauth", name, "error", err)
 		if err != nil {
+			logger.Error("Failed to setup TlsClientCert", "oauth", name, "error", err)
 			return nil, fmt.Errorf("Failed to setup TlsClientCert")
 		}