Chore: Rewrite tsdb prometheus test to standard library (#29592)

Signed-off-by: Emil Hessman <emil@hessman.se>

pkg/tsdb/prometheus/prometheus_test.go

@@ -4,21 +4,19 @@ import (
 	"testing"
 	"time"
 
+	"github.com/grafana/grafana/pkg/components/simplejson"
 	"github.com/grafana/grafana/pkg/models"
 	"github.com/grafana/grafana/pkg/tsdb"
-
-	"github.com/grafana/grafana/pkg/components/simplejson"
 	p "github.com/prometheus/common/model"
-	. "github.com/smartystreets/goconvey/convey"
+	"github.com/stretchr/testify/require"
 )
 
 func TestPrometheus(t *testing.T) {
-	Convey("Prometheus", t, func() {
 	dsInfo := &models.DataSource{
 		JsonData: simplejson.New(),
 	}
 
-		Convey("converting metric name", func() {
+	t.Run("converting metric name", func(t *testing.T) {
 		metric := map[p.LabelName]p.LabelValue{
 			p.LabelName("app"):    p.LabelValue("backend"),
 			p.LabelName("device"): p.LabelValue("mobile"),
@@ -28,10 +26,10 @@ func TestPrometheus(t *testing.T) {
 			LegendFormat: "legend {{app}} {{ device }} {{broken}}",
 		}
 
-			So(formatLegend(metric, query), ShouldEqual, "legend backend mobile ")
+		require.Equal(t, "legend backend mobile ", formatLegend(metric, query))
 	})
 
-		Convey("build full series name", func() {
+	t.Run("build full series name", func(t *testing.T) {
 		metric := map[p.LabelName]p.LabelValue{
 			p.LabelName(p.MetricNameLabel): p.LabelValue("http_request_total"),
 			p.LabelName("app"):             p.LabelValue("backend"),
@@ -42,10 +40,10 @@ func TestPrometheus(t *testing.T) {
 			LegendFormat: "",
 		}
 
-			So(formatLegend(metric, query), ShouldEqual, `http_request_total{app="backend", device="mobile"}`)
+		require.Equal(t, `http_request_total{app="backend", device="mobile"}`, formatLegend(metric, query))
 	})
 
-		Convey("parsing query model with step", func() {
+	t.Run("parsing query model with step", func(t *testing.T) {
 		json := `{
 				"expr": "go_goroutines",
 				"format": "time_series",
@@ -57,18 +55,14 @@ func TestPrometheus(t *testing.T) {
 			{Model: jsonModel},
 		}
 
-			Convey("with 48h time range", func() {
 		queryContext.TimeRange = tsdb.NewTimeRange("12h", "now")
 
 		models, err := parseQuery(dsInfo, queryModels, queryContext)
-				So(err, ShouldBeNil)
-
-				model := models[0]
-				So(model.Step, ShouldEqual, time.Second*30)
-			})
+		require.NoError(t, err)
+		require.Equal(t, time.Second*30, models[0].Step)
 	})
 
-		Convey("parsing query model without step parameter", func() {
+	t.Run("parsing query model without step parameter", func(t *testing.T) {
 		json := `{
 				"expr": "go_goroutines",
 				"format": "time_series",
@@ -81,31 +75,18 @@ func TestPrometheus(t *testing.T) {
 			{Model: jsonModel},
 		}
 
-			Convey("with 48h time range", func() {
 		queryContext.TimeRange = tsdb.NewTimeRange("48h", "now")
-
 		models, err := parseQuery(dsInfo, queryModels, queryContext)
+		require.NoError(t, err)
+		require.Equal(t, time.Minute*2, models[0].Step)
 
-				So(err, ShouldBeNil)
-
-				model := models[0]
-				So(model.Step, ShouldEqual, time.Minute*2)
-			})
-
-			Convey("with 1h time range", func() {
 		queryContext.TimeRange = tsdb.NewTimeRange("1h", "now")
-
-				models, err := parseQuery(dsInfo, queryModels, queryContext)
-
-				So(err, ShouldBeNil)
-
-				model := models[0]
-				So(model.Step, ShouldEqual, time.Second*15)
-			})
+		models, err = parseQuery(dsInfo, queryModels, queryContext)
+		require.NoError(t, err)
+		require.Equal(t, time.Second*15, models[0].Step)
 	})
 
-		Convey("parsing query model with intervalFactor", func() {
-			Convey("high intervalFactor", func() {
+	t.Run("parsing query model with high intervalFactor", func(t *testing.T) {
 		json := `{
 					"expr": "go_goroutines",
 					"format": "time_series",
@@ -118,19 +99,14 @@ func TestPrometheus(t *testing.T) {
 			{Model: jsonModel},
 		}
 
-				Convey("with 48h time range", func() {
 		queryContext.TimeRange = tsdb.NewTimeRange("48h", "now")
 
 		models, err := parseQuery(dsInfo, queryModels, queryContext)
-
-					So(err, ShouldBeNil)
-
-					model := models[0]
-					So(model.Step, ShouldEqual, time.Minute*20)
-				})
+		require.NoError(t, err)
+		require.Equal(t, time.Minute*20, models[0].Step)
 	})
 
-			Convey("low intervalFactor", func() {
+	t.Run("parsing query model with low intervalFactor", func(t *testing.T) {
 		json := `{
 					"expr": "go_goroutines",
 					"format": "time_series",
@@ -143,17 +119,10 @@ func TestPrometheus(t *testing.T) {
 			{Model: jsonModel},
 		}
 
-				Convey("with 48h time range", func() {
 		queryContext.TimeRange = tsdb.NewTimeRange("48h", "now")
 
 		models, err := parseQuery(dsInfo, queryModels, queryContext)
-
-					So(err, ShouldBeNil)
-
-					model := models[0]
-					So(model.Step, ShouldEqual, time.Minute*2)
-				})
-			})
-		})
+		require.NoError(t, err)
+		require.Equal(t, time.Minute*2, models[0].Step)
 	})
 }