Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
N
nexpie-grafana-theme
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Registry
Registry
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Kornkitt Poolsup
nexpie-grafana-theme
Commits
3c2f6094
Commit
3c2f6094
authored
Feb 14, 2019
by
Maxim Neverov
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix percent_diff calculation when points are nulls
parent
4f3b9c6c
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
23 additions
and
8 deletions
+23
-8
pkg/services/alerting/conditions/reducer.go
+11
-8
pkg/services/alerting/conditions/reducer_test.go
+12
-0
No files found.
pkg/services/alerting/conditions/reducer.go
View file @
3c2f6094
...
...
@@ -131,14 +131,17 @@ func (s *SimpleReducer) Reduce(series *tsdb.TimeSeries) null.Float {
break
}
}
// get the oldest point
points
=
points
[
0
:
i
]
for
i
:=
0
;
i
<
len
(
points
);
i
++
{
if
points
[
i
][
0
]
.
Valid
{
allNull
=
false
val
:=
(
first
-
points
[
i
][
0
]
.
Float64
)
/
points
[
i
][
0
]
.
Float64
*
100
value
=
math
.
Abs
(
val
)
break
if
i
>=
1
{
// get the oldest point
points
=
points
[
0
:
i
]
for
i
:=
0
;
i
<
len
(
points
);
i
++
{
if
points
[
i
][
0
]
.
Valid
{
allNull
=
false
val
:=
(
first
-
points
[
i
][
0
]
.
Float64
)
/
points
[
i
][
0
]
.
Float64
*
100
value
=
math
.
Abs
(
val
)
break
}
}
}
case
"count_non_null"
:
...
...
pkg/services/alerting/conditions/reducer_test.go
View file @
3c2f6094
...
...
@@ -157,6 +157,18 @@ func TestSimpleReducer(t *testing.T) {
result
:=
testReducer
(
"percent_diff"
,
30
,
40
,
40
)
So
(
result
,
ShouldEqual
,
float64
(
33.33333333333333
))
})
Convey
(
"percent_diff with only nulls"
,
func
()
{
reducer
:=
NewSimpleReducer
(
"percent_diff"
)
series
:=
&
tsdb
.
TimeSeries
{
Name
:
"test time serie"
,
}
series
.
Points
=
append
(
series
.
Points
,
tsdb
.
NewTimePoint
(
null
.
FloatFromPtr
(
nil
),
1
))
series
.
Points
=
append
(
series
.
Points
,
tsdb
.
NewTimePoint
(
null
.
FloatFromPtr
(
nil
),
2
))
So
(
reducer
.
Reduce
(
series
)
.
Valid
,
ShouldEqual
,
false
)
})
})
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment