Commit 404bf2e0 by Sean Nessworthy Committed by Erik Sundell

CloudWatch: Add ap-east-1 to hard-coded region lists (#19523)

* CloudWatch: Add ap-east-1 to hard-coded region lists (#17448)

* CloudWatch: Fix handleGetRegion tests
parent 8de6ba6a
...@@ -285,7 +285,7 @@ func (e *CloudWatchExecutor) handleGetRegions(ctx context.Context, parameters *s ...@@ -285,7 +285,7 @@ func (e *CloudWatchExecutor) handleGetRegions(ctx context.Context, parameters *s
} }
regions := []string{ regions := []string{
"ap-northeast-1", "ap-northeast-2", "ap-northeast-3", "ap-south-1", "ap-southeast-1", "ap-southeast-2", "ca-central-1", "ap-east-1", "ap-northeast-1", "ap-northeast-2", "ap-northeast-3", "ap-south-1", "ap-southeast-1", "ap-southeast-2", "ca-central-1",
"eu-central-1", "eu-north-1", "eu-west-1", "eu-west-2", "eu-west-3", "me-south-1", "sa-east-1", "us-east-1", "us-east-2", "us-west-1", "us-west-2", "eu-central-1", "eu-north-1", "eu-west-1", "eu-west-2", "eu-west-3", "me-south-1", "sa-east-1", "us-east-1", "us-east-2", "us-west-1", "us-west-2",
"cn-north-1", "cn-northwest-1", "us-gov-east-1", "us-gov-west-1", "us-isob-east-1", "us-iso-east-1", "cn-north-1", "cn-northwest-1", "us-gov-east-1", "us-gov-west-1", "us-isob-east-1", "us-iso-east-1",
} }
......
...@@ -120,8 +120,9 @@ func TestCloudWatchMetrics(t *testing.T) { ...@@ -120,8 +120,9 @@ func TestCloudWatchMetrics(t *testing.T) {
result, _ := executor.handleGetRegions(context.Background(), simplejson.New(), &tsdb.TsdbQuery{}) result, _ := executor.handleGetRegions(context.Background(), simplejson.New(), &tsdb.TsdbQuery{})
Convey("Should return regions", func() { Convey("Should return regions", func() {
So(result[0].Text, ShouldEqual, "ap-northeast-1") So(result[0].Text, ShouldEqual, "ap-east-1")
So(result[1].Text, ShouldEqual, "ap-northeast-2") So(result[1].Text, ShouldEqual, "ap-northeast-1")
So(result[2].Text, ShouldEqual, "ap-northeast-2")
}) })
}) })
......
...@@ -44,6 +44,7 @@ export class CloudWatchConfigCtrl { ...@@ -44,6 +44,7 @@ export class CloudWatchConfigCtrl {
]; ];
regions = [ regions = [
'ap-east-1',
'ap-northeast-1', 'ap-northeast-1',
'ap-northeast-2', 'ap-northeast-2',
'ap-northeast-3', 'ap-northeast-3',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment