Commit 487fd12d by Torkel Ödegaard

wip: minor update

parent 159c5cdb
...@@ -4,7 +4,7 @@ import { FadeIn } from 'app/core/components/Animations/FadeIn'; ...@@ -4,7 +4,7 @@ import { FadeIn } from 'app/core/components/Animations/FadeIn';
interface Props { interface Props {
children: JSX.Element; children: JSX.Element;
main: EditorToolBarView; main?: EditorToolBarView;
toolbarItems: EditorToolBarView[]; toolbarItems: EditorToolBarView[];
} }
...@@ -75,11 +75,13 @@ export class EditorTabBody extends PureComponent<Props, State> { ...@@ -75,11 +75,13 @@ export class EditorTabBody extends PureComponent<Props, State> {
return ( return (
<> <>
{main && (
<div className="toolbar"> <div className="toolbar">
{this.renderMainSelection(main)} {this.renderMainSelection(main)}
<div className="gf-form--grow" /> <div className="gf-form--grow" />
{toolbarItems.map(item => this.renderButton(item))} {toolbarItems.map(item => this.renderButton(item))}
</div> </div>
)}
<div className="panel-editor__scroll"> <div className="panel-editor__scroll">
<CustomScrollbar autoHide={false}> <CustomScrollbar autoHide={false}>
<div className="panel-editor__content"> <div className="panel-editor__content">
......
...@@ -4,11 +4,9 @@ import { getAngularLoader, AngularComponent } from 'app/core/services/AngularLoa ...@@ -4,11 +4,9 @@ import { getAngularLoader, AngularComponent } from 'app/core/services/AngularLoa
import { EditorTabBody } from './EditorTabBody'; import { EditorTabBody } from './EditorTabBody';
import { PanelModel } from '../panel_model'; import { PanelModel } from '../panel_model';
import { DashboardModel } from '../dashboard_model';
interface Props { interface Props {
panel: PanelModel; panel: PanelModel;
dashboard: DashboardModel;
} }
export class GeneralTab extends PureComponent<Props> { export class GeneralTab extends PureComponent<Props> {
...@@ -24,14 +22,13 @@ export class GeneralTab extends PureComponent<Props> { ...@@ -24,14 +22,13 @@ export class GeneralTab extends PureComponent<Props> {
return; return;
} }
const { panel, dashboard } = this.props; const { panel } = this.props;
const loader = getAngularLoader(); const loader = getAngularLoader();
const template = '<panel-general-tab />'; const template = '<panel-general-tab />';
const scopeProps = { const scopeProps = {
ctrl: { ctrl: {
panel: panel, panel: panel,
dashboard: dashboard,
}, },
}; };
......
...@@ -82,7 +82,7 @@ export class PanelEditor extends PureComponent<PanelEditorProps> { ...@@ -82,7 +82,7 @@ export class PanelEditor extends PureComponent<PanelEditorProps> {
</button> </button>
</div> </div>
{activeTab === 'general' && <GeneralTab panel={panel} dashboard={dashboard} />} {activeTab === 'general' && <GeneralTab panel={panel} />}
{activeTab === 'queries' && <QueriesTab panel={panel} dashboard={dashboard} />} {activeTab === 'queries' && <QueriesTab panel={panel} dashboard={dashboard} />}
{activeTab === 'visualization' && ( {activeTab === 'visualization' && (
<VisualizationTab panel={panel} dashboard={dashboard} plugin={plugin} onTypeChanged={onTypeChanged} /> <VisualizationTab panel={panel} dashboard={dashboard} plugin={plugin} onTypeChanged={onTypeChanged} />
......
import coreModule from 'app/core/core_module'; import coreModule from 'app/core/core_module';
import { DashboardModel } from '../dashboard/dashboard_model';
export class GeneralTabCtrl { export class GeneralTabCtrl {
panelCtrl: any; panelCtrl: any;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment