Commit 56bef637 by Torkel Ödegaard

feat(templating): fixes for influxdb template variable formating, #2918

parent d1bac6cd
......@@ -35,7 +35,7 @@ export function InfluxDatasource(instanceSettings, $q, backendSrv, templateSrv)
// build query
var queryModel = new InfluxQuery(target, templateSrv, options.scopedVars);
var query = queryModel.render();
var query = queryModel.render(true);
query = query.replace(/\$interval/g, (target.interval || options.interval));
return query;
......
......@@ -11,7 +11,7 @@ export default class InfluxQuery {
templateSrv: any;
scopedVars: any;
constructor(target, templateSrv, scopedVars) {
constructor(target, templateSrv?, scopedVars?) {
this.target = target;
this.templateSrv = templateSrv;
this.scopedVars = scopedVars;
......@@ -130,7 +130,7 @@ export default class InfluxQuery {
this.updatePersistedParts();
}
private renderTagCondition(tag, index) {
private renderTagCondition(tag, index, interpolate) {
var str = "";
var operator = tag.operator;
var value = tag.value;
......@@ -148,9 +148,11 @@ export default class InfluxQuery {
// quote value unless regex
if (operator !== '=~' && operator !== '!~') {
if (interpolate) {
value = this.templateSrv.replace(value, this.scopedVars);
}
value = "'" + value.replace('\\', '\\\\') + "'";
} else {
} else if (interpolate){
value = this.templateSrv.replace(value, this.scopedVars, 'regex');
}
......@@ -174,12 +176,16 @@ export default class InfluxQuery {
return policy + measurement;
}
render() {
render(interpolate?) {
var target = this.target;
if (target.rawQuery) {
if (interpolate) {
return this.templateSrv.replace(target.query, this.scopedVars, 'regex');
} else {
return target.query;
}
}
if (!target.measurement) {
throw {message: "Metric measurement is missing"};
......@@ -203,7 +209,7 @@ export default class InfluxQuery {
query += ' FROM ' + this.getMeasurementAndPolicy() + ' WHERE ';
var conditions = _.map(target.tags, (tag, index) => {
return this.renderTagCondition(tag, index);
return this.renderTagCondition(tag, index, interpolate);
});
query += conditions.join(' ');
......@@ -227,8 +233,6 @@ export default class InfluxQuery {
query += ' fill(' + target.fill + ')';
}
target.query = query;
return query;
}
}
......@@ -154,6 +154,7 @@ export class InfluxQueryCtrl extends QueryCtrl {
}
toggleEditorMode() {
this.target.query = this.queryModel.render(false);
this.target.rawQuery = !this.target.rawQuery;
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment