Commit 57dadebb by kay delaney Committed by GitHub

Explore: Improves performance of Logs element by limiting re-rendering (#17685)

* Explore: Improves performance of Logs element by limiting re-rendering
Re-renders only when query has finished executing or when deduplication
strategy changes.
Closes #17663

* Explore: Adds logsHighlighterExpressions as prop to consider when re-rendering Logs
parent 6fd4aa4b
...@@ -91,6 +91,16 @@ export class LogsContainer extends PureComponent<LogsContainerProps> { ...@@ -91,6 +91,16 @@ export class LogsContainer extends PureComponent<LogsContainerProps> {
return []; return [];
}; };
// Limit re-rendering to when a query is finished executing or when the deduplication strategy changes
// for performance reasons.
shouldComponentUpdate(nextProps: LogsContainerProps): boolean {
return (
nextProps.loading !== this.props.loading ||
nextProps.dedupStrategy !== this.props.dedupStrategy ||
nextProps.logsHighlighterExpressions !== this.props.logsHighlighterExpressions
);
}
render() { render() {
const { const {
exploreId, exploreId,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment