Chore: Replace scopelint with exportloopref (#26075)

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>

.circleci/config.yml

@@ -826,7 +826,7 @@ jobs:
           command: |
           command: |
             # To save memory, run in two batches
             # To save memory, run in two batches
             golangci-lint run -v -j 4 --config scripts/go/configs/ci/.golangci.toml -E deadcode -E depguard -E dogsled \
             golangci-lint run -v -j 4 --config scripts/go/configs/ci/.golangci.toml -E deadcode -E depguard -E dogsled \
-              -E errcheck -E goconst -E golint -E gosec -E gosimple -E govet -E scopelint -E whitespace ./pkg/...
+              -E errcheck -E goconst -E golint -E gosec -E gosimple -E govet -E exportloopref -E whitespace ./pkg/...
             golangci-lint run -v -j 4 --config scripts/go/configs/ci/.golangci.toml -E ineffassign \
             golangci-lint run -v -j 4 --config scripts/go/configs/ci/.golangci.toml -E ineffassign \
               -E rowserrcheck -E staticcheck -E structcheck -E typecheck -E unconvert -E unused -E varcheck ./pkg/...
               -E rowserrcheck -E staticcheck -E structcheck -E typecheck -E unconvert -E unused -E varcheck ./pkg/...
             ./scripts/go/bin/revive -formatter stylish -config ./scripts/go/configs/revive.toml ./pkg/...
             ./scripts/go/bin/revive -formatter stylish -config ./scripts/go/configs/revive.toml ./pkg/...

scripts/go/configs/.golangci.toml

@@ -29,7 +29,7 @@ enable = [
   # "interfacer",
   # "interfacer",
   # "misspell",
   # "misspell",
   "rowserrcheck",
   "rowserrcheck",
-  "scopelint",
+  "exportloopref",
   "staticcheck",
   "staticcheck",
   "structcheck",
   "structcheck",
   # "stylecheck",
   # "stylecheck",
@@ -45,10 +45,6 @@ enable = [
 # "unparam"
 # "unparam"
 
 
 [[issues.exclude-rules]]
 [[issues.exclude-rules]]
-path = "_test\\.go"
-linters = ["scopelint"]
-
-[[issues.exclude-rules]]
 linters = ["gosec"]
 linters = ["gosec"]
 text = "G108"
 text = "G108"
 
 

scripts/go/configs/ci/.golangci.toml

@@ -12,10 +12,6 @@ min-occurrences = 5
 disable-all = true
 disable-all = true
 
 
 [[issues.exclude-rules]]
 [[issues.exclude-rules]]
-path = "_test\\.go"
-linters = ["scopelint"]
-
-[[issues.exclude-rules]]
 linters = ["gosec"]
 linters = ["gosec"]
 text = "G108"
 text = "G108"