Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
N
nexpie-grafana-theme
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Registry
Registry
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Kornkitt Poolsup
nexpie-grafana-theme
Commits
7d105439
Commit
7d105439
authored
Feb 21, 2019
by
Torkel Ödegaard
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixed scrollbar issue introduced in theme changes
parent
1bbf7cc2
Hide whitespace changes
Inline
Side-by-side
Showing
7 changed files
with
19 additions
and
12 deletions
+19
-12
packages/grafana-ui/src/components/CustomScrollbar/CustomScrollbar.tsx
+4
-4
packages/grafana-ui/src/components/CustomScrollbar/_CustomScrollbar.scss
+8
-1
public/app/core/components/Page/Page.tsx
+1
-1
public/app/features/explore/Wrapper.tsx
+1
-1
public/sass/_variables.dark.scss
+3
-3
public/sass/_variables.light.scss
+1
-1
public/sass/components/_footer.scss
+1
-1
No files found.
packages/grafana-ui/src/components/CustomScrollbar/CustomScrollbar.tsx
View file @
7d105439
import
React
,
{
PureComponent
}
from
'react'
;
import
_
from
'lodash'
;
import
classNames
from
'classnames'
;
import
Scrollbars
from
'react-custom-scrollbars'
;
interface
Props
{
c
ustomC
lassName
?:
string
;
className
?:
string
;
autoHide
?:
boolean
;
autoHideTimeout
?:
number
;
autoHideDuration
?:
number
;
...
...
@@ -21,7 +22,6 @@ interface Props {
*/
export
class
CustomScrollbar
extends
PureComponent
<
Props
>
{
static
defaultProps
:
Partial
<
Props
>
=
{
customClassName
:
'custom-scrollbars'
,
autoHide
:
false
,
autoHideTimeout
:
200
,
autoHideDuration
:
200
,
...
...
@@ -60,7 +60,7 @@ export class CustomScrollbar extends PureComponent<Props> {
render
()
{
const
{
c
ustomC
lassName
,
className
,
children
,
autoHeightMax
,
autoHeightMin
,
...
...
@@ -75,7 +75,7 @@ export class CustomScrollbar extends PureComponent<Props> {
return
(
<
Scrollbars
ref=
{
this
.
ref
}
className=
{
c
ustomClassName
}
className=
{
c
lassNames
(
'custom-scrollbar'
,
className
)
}
onScroll=
{
setScrollTop
}
autoHeight=
{
true
}
autoHide=
{
autoHide
}
...
...
packages/grafana-ui/src/components/CustomScrollbar/_CustomScrollbar.scss
View file @
7d105439
.custom-scrollbars
{
.custom-scrollbar
{
// Fix for Firefox. For some reason sometimes .view container gets a height of its content, but in order to
// make scroll working it should fit outer container size (scroll appears only when inner container size is
// greater than outer one).
...
...
@@ -37,4 +37,11 @@
@include
gradient-horizontal
(
$scrollbarBackground
,
$scrollbarBackground2
);
border-radius
:
6px
;
}
// page scrollbar should stick to left side to aid hitting it
&
--page
{
.track-vertical
{
right
:
0
;
}
}
}
public/app/core/components/Page/Page.tsx
View file @
7d105439
...
...
@@ -48,7 +48,7 @@ class Page extends Component<Props> {
const
{
buildInfo
}
=
config
;
return
(
<
div
className=
"page-scrollbar-wrapper"
>
<
CustomScrollbar
autoHeightMin=
{
'100%'
}
>
<
CustomScrollbar
autoHeightMin=
{
'100%'
}
className=
"custom-scrollbar--page"
>
<
div
className=
"page-scrollbar-content"
>
<
PageHeader
model=
{
navModel
}
/>
{
this
.
props
.
children
}
...
...
public/app/features/explore/Wrapper.tsx
View file @
7d105439
...
...
@@ -53,7 +53,7 @@ export class Wrapper extends Component<WrapperProps> {
return
(
<
div
className=
"page-scrollbar-wrapper"
>
<
CustomScrollbar
autoHeightMin=
{
'100%'
}
>
<
CustomScrollbar
autoHeightMin=
{
'100%'
}
className=
"custom-scrollbar--page"
>
<
div
className=
"explore-wrapper"
>
<
ErrorBoundary
>
<
Explore
exploreId=
{
ExploreId
.
left
}
urlState=
{
leftState
}
/>
...
...
public/sass/_variables.dark.scss
View file @
7d105439
...
...
@@ -144,9 +144,9 @@ $list-item-shadow: $card-shadow;
$empty-list-cta-bg
:
$gray-blue
;
// Scrollbars
$scrollbarBackground
:
$dark-9
;
$scrollbarBackground2
:
$dark-
9
;
$scrollbarBorder
:
$dark-10
;
$scrollbarBackground
:
#404357
;
$scrollbarBackground2
:
$dark-
10
;
$scrollbarBorder
:
black
;
// Tables
// -------------------------
...
...
public/sass/_variables.light.scss
View file @
7d105439
...
...
@@ -131,7 +131,7 @@ $empty-list-cta-bg: $gray-6;
// Scrollbars
$scrollbarBackground
:
$gray-4
;
$scrollbarBackground2
:
$gray-4
;
$scrollbarBorder
:
$gray-
3
;
$scrollbarBorder
:
$gray-
7
;
// Tables
// -------------------------
...
...
public/sass/components/_footer.scss
View file @
7d105439
...
...
@@ -42,7 +42,7 @@
display
:
none
;
}
.is-react
.custom-scrollbar
s
.footer
{
.is-react
.custom-scrollbar
.footer
{
display
:
block
;
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment