Commit 7dbe719f by Ryan McKinley Committed by GitHub

Plugins: rename vizPlugin to panelPlugin (#16802)

parent c5097e2e
......@@ -10,7 +10,7 @@ export interface PanelPluginMeta extends PluginMeta {
hideFromList?: boolean;
sort: number;
angularPlugin: AngularPanelPlugin | null;
vizPlugin: PanelPlugin | null;
panelPlugin: PanelPlugin | null;
hasBeenImported?: boolean;
// if length>0 the query tab will show up
......
......@@ -101,7 +101,7 @@ export class DashboardPanel extends PureComponent<Props, State> {
if (importedPlugin instanceof AngularPanelPlugin) {
plugin.angularPlugin = importedPlugin as AngularPanelPlugin;
} else if (importedPlugin instanceof PanelPlugin) {
plugin.vizPlugin = importedPlugin as PanelPlugin;
plugin.panelPlugin = importedPlugin as PanelPlugin;
}
} catch (e) {
plugin = getPanelPluginNotFound(plugin.id);
......@@ -209,7 +209,7 @@ export class DashboardPanel extends PureComponent<Props, State> {
onMouseLeave={this.onMouseLeave}
style={styles}
>
{plugin.vizPlugin && this.renderReactPanel()}
{plugin.panelPlugin && this.renderReactPanel()}
{plugin.angularPlugin && this.renderAngularPanel()}
</div>
)}
......
......@@ -215,7 +215,7 @@ export class PanelChrome extends PureComponent<Props, State> {
renderPanel(width: number, height: number): JSX.Element {
const { panel, plugin } = this.props;
const { renderCounter, data, isFirstLoad } = this.state;
const PanelComponent = plugin.vizPlugin.panel;
const PanelComponent = plugin.panelPlugin.panel;
// This is only done to increase a counter that is used by backend
// image rendering (phantomjs/headless chrome) to know when to capture image
......@@ -236,7 +236,7 @@ export class PanelChrome extends PureComponent<Props, State> {
<PanelComponent
data={data}
timeRange={data.request ? data.request.range : this.timeSrv.timeRange()}
options={panel.getOptions(plugin.vizPlugin.defaults)}
options={panel.getOptions(plugin.panelPlugin.defaults)}
width={width - 2 * config.theme.panelPadding.horizontal}
height={height - PANEL_HEADER_HEIGHT - config.theme.panelPadding.vertical}
renderCounter={renderCounter}
......
......@@ -63,7 +63,7 @@ export function getPanelPluginNotFound(id: string): PanelPluginMeta {
updated: '',
version: '',
},
vizPlugin: new PanelPlugin(NotFound),
panelPlugin: new PanelPlugin(NotFound),
angularPlugin: null,
};
}
......@@ -54,7 +54,7 @@ export class VisualizationTab extends PureComponent<Props, State> {
getReactPanelOptions = () => {
const { panel, plugin } = this.props;
return panel.getOptions(plugin.vizPlugin.defaults);
return panel.getOptions(plugin.panelPlugin.defaults);
};
renderPanelOptions() {
......@@ -64,8 +64,8 @@ export class VisualizationTab extends PureComponent<Props, State> {
return <div ref={element => (this.element = element)} />;
}
if (plugin.vizPlugin) {
const PanelEditor = plugin.vizPlugin.editor;
if (plugin.panelPlugin) {
const PanelEditor = plugin.panelPlugin.editor;
if (PanelEditor) {
return <PanelEditor options={this.getReactPanelOptions()} onOptionsChange={this.onPanelOptionsChanged} />;
......
......@@ -129,7 +129,7 @@ describe('PanelModel', () => {
model.changePlugin(
getPanelPlugin({
id: 'react',
vizPlugin: reactPlugin,
panelPlugin: reactPlugin,
})
);
});
......
......@@ -255,10 +255,10 @@ export class PanelModel {
pluginLoaded(plugin: PanelPluginMeta) {
this.plugin = plugin;
if (plugin.vizPlugin && plugin.vizPlugin.onPanelMigration) {
if (plugin.panelPlugin && plugin.panelPlugin.onPanelMigration) {
const version = this.getPluginVersion(plugin);
if (version !== this.pluginVersion) {
this.options = plugin.vizPlugin.onPanelMigration(this);
this.options = plugin.panelPlugin.onPanelMigration(this);
this.pluginVersion = version;
}
}
......@@ -291,7 +291,7 @@ export class PanelModel {
this.plugin = newPlugin;
// Let panel plugins inspect options from previous panel and keep any that it can use
const reactPanel = newPlugin.vizPlugin;
const reactPanel = newPlugin.panelPlugin;
if (reactPanel) {
if (reactPanel.onPanelTypeChanged) {
......
......@@ -57,7 +57,7 @@ export const getPanelPlugin = (options: Partial<PanelPluginMeta>): PanelPluginMe
hideFromList: options.hideFromList === true,
module: '',
baseUrl: '',
vizPlugin: options.vizPlugin,
panelPlugin: options.panelPlugin,
angularPlugin: options.angularPlugin,
};
};
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment