Backend plugins: Renderer v2 plugin (#23625)

grafana-plugin-model is legacy and is replaced by new backend 
plugins SDK and architecture. Renderer is not part of SDK and 
we want to keep it that way for now since it's highly unlikely there 
will be more than one kind of renderer plugin.
So this PR adds support for renderer plugin v2.
Also adds support sending a Device Scale Factor parameter to the 
plugin v2 remote rendering service and by that replaces #22474.
Adds support sending a Headers parameter to the plugin v2 and
remote rendering service which for now only include 
Accect-Language header (the user locale in browser when using 
Grafana), ref grafana/grafana-image-renderer#45.
Fixes health check json details response.
Adds image renderer plugin configuration settings in defaults.ini 
and sample.ini.

Co-Authored-By: Arve Knudsen <arve.knudsen@gmail.com>

Makefile

@@ -4,7 +4,7 @@
 
 -include local/Makefile
 
-.PHONY: all deps-go deps-js deps build-go build-server build-cli build-js build build-docker-dev build-docker-full lint-go gosec revive golangci-lint go-vet test-go test-js test run run-frontend clean devenv devenv-down revive-alerting help
+.PHONY: all deps-go deps-js deps build-go build-server build-cli build-js build build-docker-dev build-docker-full lint-go gosec revive golangci-lint go-vet test-go test-js test run run-frontend clean devenv devenv-down revive-alerting protobuf help
 
 GO = GO111MODULE=on go
 GO_FILES ?= ./pkg/...
@@ -161,6 +161,16 @@ devenv-down: ## Stop optional services.
 
 ##@ Helpers
 
+# We separate the protobuf generation because most development tasks on
+# Grafana do not involve changing protobuf files and protoc is not a
+# go-gettable dependency and so getting it installed can be inconvenient.
+#
+# If you are working on changes to protobuf interfaces you may either use
+# this target or run the individual scripts below directly.
+protobuf: ## Compile protobuf definitions
+	bash scripts/protobuf-check.sh
+	bash pkg/plugins/backendplugin/pluginextensionv2/generate.sh
+
 clean: ## Clean up intermediate build artifacts.
 	@echo "cleaning"
 	rm -rf node_modules

conf/defaults.ini

@@ -693,6 +693,66 @@ disable_sanitize_html = false
 enable_alpha = false
 app_tls_skip_verify_insecure = false
 
+#################################### Grafana Image Renderer Plugin ##########################
+[plugin.grafana-image-renderer]
+# Instruct headless browser instance to use a default timezone when not provided by Grafana, e.g. when rendering panel image of alert.
+# See ICU’s metaZones.txt (https://cs.chromium.org/chromium/src/third_party/icu/source/data/misc/metaZones.txt) for a list of supported
+# timezone IDs. Fallbacks to TZ environment variable if not set.
+rendering_timezone =
+
+# Instruct headless browser instance to use a default language when not provided by Grafana, e.g. when rendering panel image of alert.
+# Please refer to the HTTP header Accept-Language to understand how to format this value, e.g. 'fr-CH, fr;q=0.9, en;q=0.8, de;q=0.7, *;q=0.5'.
+rendering_language =
+
+# Instruct headless browser instance to use a default device scale factor when not provided by Grafana, e.g. when rendering panel image of alert.
+# Default is 1. Using a higher value will produce more detailed images (higher DPI), but will require more disk space to store an image.
+rendering_viewport_device_scale_factor =
+
+# Instruct headless browser instance whether to ignore HTTPS errors during navigation. Per default HTTPS errors are not ignored. Due to
+# the security risk it's not recommended to ignore HTTPS errors.
+rendering_ignore_https_errors =
+
+# Instruct headless browser instance whether to capture and log verbose information when rendering an image. Default is false and will
+# only capture and log error messages. When enabled, debug messages are captured and logged as well.
+# For the verbose information to be included in the Grafana server log you have to adjust the rendering log level to debug, configure
+# [log].filter = rendering:debug.
+rendering_verbose_logging =
+
+# Instruct headless browser instance whether to output its debug and error messages into running process of remote rendering service.
+# Default is false. This can be useful to enable (true) when troubleshooting.
+rendering_dumpio =
+
+# Additional arguments to pass to the headless browser instance. Default is --no-sandbox. The list of Chromium flags can be found
+# here (https://peter.sh/experiments/chromium-command-line-switches/). Multiple arguments is separated with comma-character.
+rendering_args =
+
+# You can configure the plugin to use a different browser binary instead of the pre-packaged version of Chromium.
+# Please note that this is not recommended, since you may encounter problems if the installed version of Chrome/Chromium is not
+# compatible with the plugin.
+rendering_chrome_bin =
+
+# Instruct how headless browser instances are created. Default is 'default' and will create a new browser instance on each request.
+# Mode 'clustered' will make sure that only a maximum of browsers/incognito pages can execute concurrently.
+# Mode 'reusable' will have one browser instance and will create a new incognito page on each request.
+rendering_mode =
+
+# When rendering_mode = clustered you can instruct how many browsers or incognito pages can execute concurrently. Default is 'browser'
+# and will cluster using browser instances.
+# Mode 'context' will cluster using incognito pages.
+rendering_clustering_mode =
+# When rendering_mode = clustered you can define maximum number of browser instances/incognito pages that can execute concurrently..
+rendering_clustering_max_concurrency =
+
+# Limit the maxiumum viewport width, height and device scale factor that can be requested.
+rendering_viewport_max_width =
+rendering_viewport_max_height =
+rendering_viewport_max_device_scale_factor =
+
+# Change the listening host and port of the gRPC server. Default host is 127.0.0.1 and default port is 0 and will automatically assign
+# a port not in use.
+grpc_host =
+grpc_port =
+
 [enterprise]
 license_path =
 

conf/sample.ini

@@ -682,6 +682,66 @@
 ;enable_alpha = false
 ;app_tls_skip_verify_insecure = false
 
+#################################### Grafana Image Renderer Plugin ##########################
+[plugin.grafana-image-renderer]
+# Instruct headless browser instance to use a default timezone when not provided by Grafana, e.g. when rendering panel image of alert.
+# See ICU’s metaZones.txt (https://cs.chromium.org/chromium/src/third_party/icu/source/data/misc/metaZones.txt) for a list of supported
+# timezone IDs. Fallbacks to TZ environment variable if not set.
+;rendering_timezone =
+
+# Instruct headless browser instance to use a default language when not provided by Grafana, e.g. when rendering panel image of alert.
+# Please refer to the HTTP header Accept-Language to understand how to format this value, e.g. 'fr-CH, fr;q=0.9, en;q=0.8, de;q=0.7, *;q=0.5'.
+;rendering_language =
+
+# Instruct headless browser instance to use a default device scale factor when not provided by Grafana, e.g. when rendering panel image of alert.
+# Default is 1. Using a higher value will produce more detailed images (higher DPI), but will require more disk space to store an image.
+;rendering_viewport_device_scale_factor =
+
+# Instruct headless browser instance whether to ignore HTTPS errors during navigation. Per default HTTPS errors are not ignored. Due to
+# the security risk it's not recommended to ignore HTTPS errors.
+;rendering_ignore_https_errors =
+
+# Instruct headless browser instance whether to capture and log verbose information when rendering an image. Default is false and will
+# only capture and log error messages. When enabled, debug messages are captured and logged as well.
+# For the verbose information to be included in the Grafana server log you have to adjust the rendering log level to debug, configure
+# [log].filter = rendering:debug.
+;rendering_verbose_logging =
+
+# Instruct headless browser instance whether to output its debug and error messages into running process of remote rendering service.
+# Default is false. This can be useful to enable (true) when troubleshooting.
+;rendering_dumpio =
+
+# Additional arguments to pass to the headless browser instance. Default is --no-sandbox. The list of Chromium flags can be found
+# here (https://peter.sh/experiments/chromium-command-line-switches/). Multiple arguments is separated with comma-character.
+;rendering_args =
+
+# You can configure the plugin to use a different browser binary instead of the pre-packaged version of Chromium.
+# Please note that this is not recommended, since you may encounter problems if the installed version of Chrome/Chromium is not
+# compatible with the plugin.
+;rendering_chrome_bin =
+
+# Instruct how headless browser instances are created. Default is 'default' and will create a new browser instance on each request.
+# Mode 'clustered' will make sure that only a maximum of browsers/incognito pages can execute concurrently.
+# Mode 'reusable' will have one browser instance and will create a new incognito page on each request.
+;rendering_mode =
+
+# When rendering_mode = clustered you can instruct how many browsers or incognito pages can execute concurrently. Default is 'browser'
+# and will cluster using browser instances.
+# Mode 'context' will cluster using incognito pages.
+;rendering_clustering_mode =
+# When rendering_mode = clustered you can define maximum number of browser instances/incognito pages that can execute concurrently..
+;rendering_clustering_max_concurrency =
+
+# Limit the maxiumum viewport width, height and device scale factor that can be requested.
+;rendering_viewport_max_width =
+;rendering_viewport_max_height =
+;rendering_viewport_max_device_scale_factor =
+
+# Change the listening host and port of the gRPC server. Default host is 127.0.0.1 and default port is 0 and will automatically assign
+# a port not in use.
+;grpc_host =
+;grpc_port =
+
 [enterprise]
 # Path to a valid Grafana Enterprise license.jwt file
 ;license_path =

go.mod

@@ -26,6 +26,7 @@ require (
 	github.com/go-sql-driver/mysql v1.4.1
 	github.com/go-stack/stack v1.8.0
 	github.com/gobwas/glob v0.2.3
+	github.com/golang/protobuf v1.3.4
 	github.com/google/go-cmp v0.3.1
 	github.com/gorilla/websocket v1.4.1
 	github.com/gosimple/slug v1.4.2

pkg/api/datasources.go

@@ -386,15 +386,14 @@ func (hs *HTTPServer) CheckDatasourceHealth(c *models.ReqContext) {
 		return
 	}
 
-	var jsonDetails map[string]interface{}
 	payload := map[string]interface{}{
 		"status":  resp.Status.String(),
 		"message": resp.Message,
-		"details": jsonDetails,
 	}
 
 	// Unmarshal JSONDetails if it's not empty.
 	if len(resp.JSONDetails) > 0 {
+		var jsonDetails map[string]interface{}
 		err = json.Unmarshal(resp.JSONDetails, &jsonDetails)
 		if err != nil {
 			c.JsonApiErr(500, "Failed to unmarshal detailed response from backend plugin", err)

pkg/api/plugins.go

 package api
 
 import (
+	"encoding/json"
 	"errors"
 	"net/http"
 	"sort"
@@ -317,9 +318,19 @@ func (hs *HTTPServer) CheckHealth(c *models.ReqContext) Response {
 	}
 
 	payload := map[string]interface{}{
-		"status":      resp.Status.String(),
-		"message":     resp.Message,
-		"jsonDetails": resp.JSONDetails,
+		"status":  resp.Status.String(),
+		"message": resp.Message,
+	}
+
+	// Unmarshal JSONDetails if it's not empty.
+	if len(resp.JSONDetails) > 0 {
+		var jsonDetails map[string]interface{}
+		err = json.Unmarshal(resp.JSONDetails, &jsonDetails)
+		if err != nil {
+			return Error(500, "Failed to unmarshal detailed response from backend plugin", err)
+		}
+
+		payload["details"] = jsonDetails
 	}
 
 	if resp.Status != backendplugin.HealthStatusOk {

pkg/api/render.go

@@ -40,18 +40,32 @@ func (hs *HTTPServer) RenderToPng(c *models.ReqContext) {
 		return
 	}
 
+	scale, err := strconv.ParseFloat(queryReader.Get("scale", "1"), 64)
+	if err != nil {
+		c.Handle(400, "Render parameters error", fmt.Errorf("Cannot parse scale as float: %s", err))
+		return
+	}
+
+	headers := http.Header{}
+	acceptLanguageHeader := c.Req.Header.Values("Accept-Language")
+	if len(acceptLanguageHeader) > 0 {
+		headers["Accept-Language"] = acceptLanguageHeader
+	}
+
 	maxConcurrentLimitForApiCalls := 30
 	result, err := hs.RenderService.Render(c.Req.Context(), rendering.Opts{
-		Width:           width,
-		Height:          height,
-		Timeout:         time.Duration(timeout) * time.Second,
-		OrgId:           c.OrgId,
-		UserId:          c.UserId,
-		OrgRole:         c.OrgRole,
-		Path:            c.Params("*") + queryParams,
-		Timezone:        queryReader.Get("tz", ""),
-		Encoding:        queryReader.Get("encoding", ""),
-		ConcurrentLimit: maxConcurrentLimitForApiCalls,
+		Width:             width,
+		Height:            height,
+		Timeout:           time.Duration(timeout) * time.Second,
+		OrgId:             c.OrgId,
+		UserId:            c.UserId,
+		OrgRole:           c.OrgRole,
+		Path:              c.Params("*") + queryParams,
+		Timezone:          queryReader.Get("tz", ""),
+		Encoding:          queryReader.Get("encoding", ""),
+		ConcurrentLimit:   maxConcurrentLimitForApiCalls,
+		DeviceScaleFactor: scale,
+		Headers:           headers,
 	})
 
 	if err != nil && err == rendering.ErrTimeout {

pkg/plugins/backendplugin/backend_plugin.go

@@ -6,15 +6,15 @@ import (
 	"net/http"
 	"time"
 
-	"github.com/grafana/grafana-plugin-sdk-go/genproto/pluginv2"
-	"google.golang.org/grpc/codes"
-	"google.golang.org/grpc/status"
-
 	datasourceV1 "github.com/grafana/grafana-plugin-model/go/datasource"
 	rendererV1 "github.com/grafana/grafana-plugin-model/go/renderer"
+	"github.com/grafana/grafana-plugin-sdk-go/genproto/pluginv2"
 	"github.com/grafana/grafana/pkg/infra/log"
+	"github.com/grafana/grafana/pkg/plugins/backendplugin/pluginextensionv2"
 	"github.com/grafana/grafana/pkg/util/errutil"
 	plugin "github.com/hashicorp/go-plugin"
+	"google.golang.org/grpc/codes"
+	"google.golang.org/grpc/status"
 )
 
 // BackendPlugin a registered backend plugin.
@@ -61,6 +61,11 @@ func (p *BackendPlugin) start(ctx context.Context) error {
 			return err
 		}
 
+		rawRenderer, err := rpcClient.Dispense("renderer")
+		if err != nil {
+			return err
+		}
+
 		if rawDiagnostics != nil {
 			if plugin, ok := rawDiagnostics.(DiagnosticsPlugin); ok {
 				p.diagnostics = plugin
@@ -86,6 +91,12 @@ func (p *BackendPlugin) start(ctx context.Context) error {
 				client.TransformPlugin = plugin
 			}
 		}
+
+		if rawRenderer != nil {
+			if plugin, ok := rawRenderer.(pluginextensionv2.RendererPlugin); ok {
+				client.RendererPlugin = plugin
+			}
+		}
 	} else {
 		raw, err := rpcClient.Dispense(p.id)
 		if err != nil {

pkg/plugins/backendplugin/client.go

@@ -3,11 +3,11 @@ package backendplugin
 import (
 	"os/exec"
 
-	"github.com/grafana/grafana-plugin-sdk-go/backend/grpcplugin"
-	"github.com/grafana/grafana/pkg/infra/log"
-
 	datasourceV1 "github.com/grafana/grafana-plugin-model/go/datasource"
 	rendererV1 "github.com/grafana/grafana-plugin-model/go/renderer"
+	"github.com/grafana/grafana-plugin-sdk-go/backend/grpcplugin"
+	"github.com/grafana/grafana/pkg/infra/log"
+	"github.com/grafana/grafana/pkg/plugins/backendplugin/pluginextensionv2"
 	goplugin "github.com/hashicorp/go-plugin"
 )
 
@@ -64,6 +64,17 @@ type PluginDescriptor struct {
 	startFns         PluginStartFuncs
 }
 
+// getV2PluginSet returns list of plugins supported on v2.
+func getV2PluginSet() goplugin.PluginSet {
+	return goplugin.PluginSet{
+		"diagnostics": &grpcplugin.DiagnosticsGRPCPlugin{},
+		"resource":    &grpcplugin.ResourceGRPCPlugin{},
+		"data":        &grpcplugin.DataGRPCPlugin{},
+		"transform":   &grpcplugin.TransformGRPCPlugin{},
+		"renderer":    &pluginextensionv2.RendererGRPCPlugin{},
+	}
+}
+
 // NewBackendPluginDescriptor creates a new backend plugin descriptor
 // used for registering a backend datasource plugin.
 func NewBackendPluginDescriptor(pluginID, executablePath string, startFns PluginStartFuncs) PluginDescriptor {
@@ -75,12 +86,7 @@ func NewBackendPluginDescriptor(pluginID, executablePath string, startFns Plugin
 			DefaultProtocolVersion: {
 				pluginID: &datasourceV1.DatasourcePluginImpl{},
 			},
-			grpcplugin.ProtocolVersion: {
-				"diagnostics": &grpcplugin.DiagnosticsGRPCPlugin{},
-				"resource":    &grpcplugin.ResourceGRPCPlugin{},
-				"data":        &grpcplugin.DataGRPCPlugin{},
-				"transform":   &grpcplugin.TransformGRPCPlugin{},
-			},
+			grpcplugin.ProtocolVersion: getV2PluginSet(),
 		},
 		startFns: startFns,
 	}
@@ -97,6 +103,7 @@ func NewRendererPluginDescriptor(pluginID, executablePath string, startFns Plugi
 			DefaultProtocolVersion: {
 				pluginID: &rendererV1.RendererPluginImpl{},
 			},
+			grpcplugin.ProtocolVersion: getV2PluginSet(),
 		},
 		startFns: startFns,
 	}
@@ -129,4 +136,5 @@ type Client struct {
 	ResourcePlugin  ResourcePlugin
 	DataPlugin      DataPlugin
 	TransformPlugin TransformPlugin
+	RendererPlugin  pluginextensionv2.RendererPlugin
 }

pkg/plugins/backendplugin/pluginextensionv2/generate.sh

+#!/bin/bash
+
+# To compile all protobuf files in this repository, run
+# "make protobuf" at the top-level.
+
+set -eu
+
+DST_DIR=../genproto/pluginv2
+
+SOURCE="${BASH_SOURCE[0]}"
+while [ -h "$SOURCE" ] ; do SOURCE="$(readlink "$SOURCE")"; done
+DIR="$( cd -P "$( dirname "$SOURCE" )" && pwd )"
+
+cd "$DIR"
+
+protoc -I ./ rendererv2.proto --go_out=plugins=grpc:./
\ No newline at end of file

pkg/plugins/backendplugin/pluginextensionv2/renderer_grpc_plugin.go

+package pluginextensionv2
+
+import (
+	"context"
+
+	"github.com/hashicorp/go-plugin"
+	"google.golang.org/grpc"
+)
+
+type RendererPlugin interface {
+	RendererClient
+}
+
+type RendererGRPCPlugin struct {
+	plugin.NetRPCUnsupportedPlugin
+}
+
+func (p *RendererGRPCPlugin) GRPCServer(broker *plugin.GRPCBroker, s *grpc.Server) error {
+	return nil
+}
+
+func (p *RendererGRPCPlugin) GRPCClient(ctx context.Context, broker *plugin.GRPCBroker, c *grpc.ClientConn) (interface{}, error) {
+	return &RendererGRPCClient{NewRendererClient(c)}, nil
+}
+
+type RendererGRPCClient struct {
+	RendererClient
+}
+
+func (m *RendererGRPCClient) Render(ctx context.Context, req *RenderRequest, opts ...grpc.CallOption) (*RenderResponse, error) {
+	return m.RendererClient.Render(ctx, req)
+}
+
+var _ RendererClient = &RendererGRPCClient{}
+var _ plugin.GRPCPlugin = &RendererGRPCPlugin{}

pkg/plugins/backendplugin/pluginextensionv2/rendererv2.proto

+syntax = "proto3";
+package pluginextensionv2;
+
+option go_package = ".;pluginextensionv2";
+
+message StringList {
+  repeated string values = 1;
+}
+
+message RenderRequest {
+  string url = 1;
+  int32 width = 2;
+  int32 height = 3;
+  float deviceScaleFactor = 4;
+  string filePath = 5;
+  string renderKey = 6;
+  string domain = 7;
+  int32 timeout = 8;
+  string timezone = 9;
+  map<string, StringList> headers = 10;
+}
+
+message RenderResponse {
+  string error = 1;
+}
+
+service Renderer {
+  rpc Render(RenderRequest) returns (RenderResponse);
+}

pkg/plugins/renderer_plugin.go

@@ -8,6 +8,7 @@ import (
 	pluginModel "github.com/grafana/grafana-plugin-model/go/renderer"
 	"github.com/grafana/grafana/pkg/infra/log"
 	"github.com/grafana/grafana/pkg/plugins/backendplugin"
+	"github.com/grafana/grafana/pkg/plugins/backendplugin/pluginextensionv2"
 	"github.com/grafana/grafana/pkg/util/errutil"
 )
 
@@ -15,7 +16,8 @@ type RendererPlugin struct {
 	PluginBase
 
 	Executable           string `json:"executable,omitempty"`
-	GrpcPlugin           pluginModel.RendererPlugin
+	GrpcPluginV1         pluginModel.RendererPlugin
+	GrpcPluginV2         pluginextensionv2.RendererPlugin
 	backendPluginManager backendplugin.Manager
 }
 
@@ -34,6 +36,7 @@ func (r *RendererPlugin) Load(decoder *json.Decoder, pluginDir string, backendPl
 	fullpath := path.Join(r.PluginDir, cmd)
 	descriptor := backendplugin.NewRendererPluginDescriptor(r.Id, fullpath, backendplugin.PluginStartFuncs{
 		OnLegacyStart: r.onLegacyPluginStart,
+		OnStart:       r.onPluginStart,
 	})
 	if err := backendPluginManager.Register(descriptor); err != nil {
 		return errutil.Wrapf(err, "Failed to register backend plugin")
@@ -52,6 +55,11 @@ func (r *RendererPlugin) Start(ctx context.Context) error {
 }
 
 func (r *RendererPlugin) onLegacyPluginStart(pluginID string, client *backendplugin.LegacyClient, logger log.Logger) error {
-	r.GrpcPlugin = client.RendererPlugin
+	r.GrpcPluginV1 = client.RendererPlugin
+	return nil
+}
+
+func (r *RendererPlugin) onPluginStart(pluginID string, client *backendplugin.Client, logger log.Logger) error {
+	r.GrpcPluginV2 = client.RendererPlugin
 	return nil
 }

pkg/services/rendering/http_mode.go

@@ -46,6 +46,7 @@ func (rs *RenderingService) renderViaHttp(ctx context.Context, renderKey string,
 	queryParams.Add("timezone", isoTimeOffsetToPosixTz(opts.Timezone))
 	queryParams.Add("encoding", opts.Encoding)
 	queryParams.Add("timeout", strconv.Itoa(int(opts.Timeout.Seconds())))
+	queryParams.Add("deviceScaleFactor", fmt.Sprintf("%f", opts.DeviceScaleFactor))
 	rendererUrl.RawQuery = queryParams.Encode()
 
 	req, err := http.NewRequest("GET", rendererUrl.String(), nil)
@@ -55,6 +56,10 @@ func (rs *RenderingService) renderViaHttp(ctx context.Context, renderKey string,
 
 	req.Header.Set("User-Agent", fmt.Sprintf("Grafana/%s", setting.BuildVersion))
 
+	for k, v := range opts.Headers {
+		req.Header[k] = v
+	}
+
 	// gives service some additional time to timeout and return possible errors.
 	reqContext, cancel := context.WithTimeout(ctx, opts.Timeout+time.Second*2)
 	defer cancel()

pkg/services/rendering/interface.go

@@ -13,16 +13,18 @@ var ErrNoRenderer = errors.New("No renderer plugin found nor is an external rend
 var ErrPhantomJSNotInstalled = errors.New("PhantomJS executable not found")
 
 type Opts struct {
-	Width           int
-	Height          int
-	Timeout         time.Duration
-	OrgId           int64
-	UserId          int64
-	OrgRole         models.RoleType
-	Path            string
-	Encoding        string
-	Timezone        string
-	ConcurrentLimit int
+	Width             int
+	Height            int
+	Timeout           time.Duration
+	OrgId             int64
+	UserId            int64
+	OrgRole           models.RoleType
+	Path              string
+	Encoding          string
+	Timezone          string
+	ConcurrentLimit   int
+	DeviceScaleFactor float64
+	Headers           map[string][]string
 }
 
 type RenderResult struct {

pkg/services/rendering/plugin_mode.go

@@ -6,6 +6,7 @@ import (
 	"time"
 
 	pluginModel "github.com/grafana/grafana-plugin-model/go/renderer"
+	"github.com/grafana/grafana/pkg/plugins/backendplugin/pluginextensionv2"
 )
 
 func (rs *RenderingService) startPlugin(ctx context.Context) error {
@@ -13,15 +14,23 @@ func (rs *RenderingService) startPlugin(ctx context.Context) error {
 }
 
 func (rs *RenderingService) renderViaPlugin(ctx context.Context, renderKey string, opts Opts) (*RenderResult, error) {
+	// gives plugin some additional time to timeout and return possible errors.
+	ctx, cancel := context.WithTimeout(ctx, opts.Timeout+time.Second*2)
+	defer cancel()
+
+	if rs.pluginInfo.GrpcPluginV2 != nil {
+		return rs.renderViaPluginV2(ctx, renderKey, opts)
+	}
+
+	return rs.renderViaPluginV1(ctx, renderKey, opts)
+}
+
+func (rs *RenderingService) renderViaPluginV1(ctx context.Context, renderKey string, opts Opts) (*RenderResult, error) {
 	pngPath, err := rs.getFilePathForNewImage()
 	if err != nil {
 		return nil, err
 	}
 
-	// gives plugin some additional time to timeout and return possible errors.
-	ctx, cancel := context.WithTimeout(ctx, opts.Timeout+time.Second*2)
-	defer cancel()
-
 	req := &pluginModel.RenderRequest{
 		Url:       rs.getURL(opts.Path),
 		Width:     int32(opts.Width),
@@ -35,7 +44,46 @@ func (rs *RenderingService) renderViaPlugin(ctx context.Context, renderKey strin
 	}
 	rs.log.Debug("calling renderer plugin", "req", req)
 
-	rsp, err := rs.pluginInfo.GrpcPlugin.Render(ctx, req)
+	rsp, err := rs.pluginInfo.GrpcPluginV1.Render(ctx, req)
+	if err != nil {
+		return nil, err
+	}
+	if rsp.Error != "" {
+		return nil, fmt.Errorf("rendering failed: %v", rsp.Error)
+	}
+
+	return &RenderResult{FilePath: pngPath}, nil
+}
+
+func (rs *RenderingService) renderViaPluginV2(ctx context.Context, renderKey string, opts Opts) (*RenderResult, error) {
+	pngPath, err := rs.getFilePathForNewImage()
+	if err != nil {
+		return nil, err
+	}
+
+	headers := map[string]*pluginextensionv2.StringList{}
+
+	for k, values := range opts.Headers {
+		headers[k] = &pluginextensionv2.StringList{
+			Values: values,
+		}
+	}
+
+	req := &pluginextensionv2.RenderRequest{
+		Url:               rs.getURL(opts.Path),
+		Width:             int32(opts.Width),
+		Height:            int32(opts.Height),
+		DeviceScaleFactor: float32(opts.DeviceScaleFactor),
+		FilePath:          pngPath,
+		Timeout:           int32(opts.Timeout.Seconds()),
+		RenderKey:         renderKey,
+		Timezone:          isoTimeOffsetToPosixTz(opts.Timezone),
+		Domain:            rs.domain,
+		Headers:           headers,
+	}
+	rs.log.Debug("Calling renderer plugin", "req", req)
+
+	rsp, err := rs.pluginInfo.GrpcPluginV2.Render(ctx, req)
 	if err != nil {
 		return nil, err
 	}

pkg/services/rendering/rendering.go

@@ -3,6 +3,7 @@ package rendering
 import (
 	"context"
 	"fmt"
+	"math"
 	"net/url"
 	"os"
 	"path/filepath"
@@ -115,23 +116,27 @@ func (rs *RenderingService) Render(ctx context.Context, opts Opts) (*RenderResul
 		}, nil
 	}
 
-	if rs.renderAction != nil {
-		rs.log.Info("Rendering", "path", opts.Path)
-		renderKey, err := rs.generateAndStoreRenderKey(opts.OrgId, opts.UserId, opts.OrgRole)
-		if err != nil {
-			return nil, err
-		}
+	if rs.renderAction == nil {
+		return nil, fmt.Errorf("no renderer found")
+	}
 
-		defer rs.deleteRenderKey(renderKey)
+	rs.log.Info("Rendering", "path", opts.Path)
+	if math.IsInf(opts.DeviceScaleFactor, 0) || math.IsNaN(opts.DeviceScaleFactor) || opts.DeviceScaleFactor <= 0 {
+		opts.DeviceScaleFactor = 1
+	}
+	renderKey, err := rs.generateAndStoreRenderKey(opts.OrgId, opts.UserId, opts.OrgRole)
+	if err != nil {
+		return nil, err
+	}
 
-		defer func() {
-			rs.inProgressCount--
-		}()
+	defer rs.deleteRenderKey(renderKey)
 
-		rs.inProgressCount++
-		return rs.renderAction(ctx, renderKey, opts)
-	}
-	return nil, fmt.Errorf("No renderer found")
+	defer func() {
+		rs.inProgressCount--
+	}()
+
+	rs.inProgressCount++
+	return rs.renderAction(ctx, renderKey, opts)
 }
 
 func (rs *RenderingService) GetRenderUser(key string) (*RenderUser, bool) {

scripts/protobuf-check.sh

+#!/usr/bin/env bash
+
+# Check whether protobuf & go plugin are installed
+PROTOC_HELP_URL="http://google.github.io/proto-lens/installing-protoc.html"
+PROTOC_GEN_GO_HELP_URL="https://github.com/golang/protobuf/tree/v1.3.4#installation"
+
+EXIT_CODE=0
+
+if ! [ -x "$(command -v protoc)" ]; then
+	echo "Protocol Buffers not found."
+	echo "Please install Protocol Buffers and ensure 'protoc' is available in your PATH."
+	echo "See ${PROTOC_HELP_URL} for more."
+	echo
+	EXIT_CODE=1
+fi
+
+if ! [ -x "$(command -v protoc-gen-go)" ]; then
+	echo "Protocol Buffers Go plugin not found."
+	echo "Please install the plugin and ensure 'protoc-gen-go' is available in your PATH."
+	echo "See ${PROTOC_GEN_GO_HELP_URL} for more."
+	echo
+	EXIT_CODE=1
+fi
+
+exit $EXIT_CODE
\ No newline at end of file

vendor/modules.txt

@@ -144,6 +144,7 @@ github.com/gobwas/glob/syntax/lexer
 github.com/gobwas/glob/util/runes
 github.com/gobwas/glob/util/strings
 # github.com/golang/protobuf v1.3.4
+## explicit
 github.com/golang/protobuf/proto
 github.com/golang/protobuf/protoc-gen-go/descriptor
 github.com/golang/protobuf/ptypes