Commit 8a0d5aa3 by Utkarsh Bhatnagar Committed by Torkel Ödegaard

[Bug Fix] #5136 (#5142)

parent bbea698a
...@@ -173,8 +173,8 @@ export default class TimeSeries { ...@@ -173,8 +173,8 @@ export default class TimeSeries {
isMsResolutionNeeded() { isMsResolutionNeeded() {
for (var i = 0; i < this.datapoints.length; i++) { for (var i = 0; i < this.datapoints.length; i++) {
if (this.datapoints[i][0] !== null) { if (this.datapoints[i][1] !== null) {
var timestamp = this.datapoints[i][0].toString(); var timestamp = this.datapoints[i][1].toString();
if (timestamp.length === 13 && (timestamp % 1000) !== 0) { if (timestamp.length === 13 && (timestamp % 1000) !== 0) {
return true; return true;
} }
......
...@@ -22,8 +22,8 @@ describe('GraphCtrl', function() { ...@@ -22,8 +22,8 @@ describe('GraphCtrl', function() {
describe('msResolution with second resolution timestamps', function() { describe('msResolution with second resolution timestamps', function() {
beforeEach(function() { beforeEach(function() {
var data = [ var data = [
{ target: 'test.cpu1', datapoints: [[1234567890, 45], [1234567899, 60]]}, { target: 'test.cpu1', datapoints: [[45, 1234567890], [60, 1234567899]]},
{ target: 'test.cpu2', datapoints: [[1236547890, 55], [1234456709, 90]]} { target: 'test.cpu2', datapoints: [[55, 1236547890], [90, 1234456709]]}
]; ];
ctx.ctrl.panel.tooltip.msResolution = false; ctx.ctrl.panel.tooltip.msResolution = false;
ctx.ctrl.onDataReceived(data); ctx.ctrl.onDataReceived(data);
...@@ -37,8 +37,8 @@ describe('GraphCtrl', function() { ...@@ -37,8 +37,8 @@ describe('GraphCtrl', function() {
describe('msResolution with millisecond resolution timestamps', function() { describe('msResolution with millisecond resolution timestamps', function() {
beforeEach(function() { beforeEach(function() {
var data = [ var data = [
{ target: 'test.cpu1', datapoints: [[1234567890000, 45], [1234567899000, 60]]}, { target: 'test.cpu1', datapoints: [[45, 1234567890000], [60, 1234567899000]]},
{ target: 'test.cpu2', datapoints: [[1236547890001, 55], [1234456709000, 90]]} { target: 'test.cpu2', datapoints: [[55, 1236547890001], [90, 1234456709000]]}
]; ];
ctx.ctrl.panel.tooltip.msResolution = false; ctx.ctrl.panel.tooltip.msResolution = false;
ctx.ctrl.onDataReceived(data); ctx.ctrl.onDataReceived(data);
...@@ -52,8 +52,8 @@ describe('GraphCtrl', function() { ...@@ -52,8 +52,8 @@ describe('GraphCtrl', function() {
describe('msResolution with millisecond resolution timestamps but with trailing zeroes', function() { describe('msResolution with millisecond resolution timestamps but with trailing zeroes', function() {
beforeEach(function() { beforeEach(function() {
var data = [ var data = [
{ target: 'test.cpu1', datapoints: [[1234567890000, 45], [1234567899000, 60]]}, { target: 'test.cpu1', datapoints: [[45, 1234567890000], [60, 1234567899000]]},
{ target: 'test.cpu2', datapoints: [[1236547890000, 55], [1234456709000, 90]]} { target: 'test.cpu2', datapoints: [[55, 1236547890000], [90, 1234456709000]]}
]; ];
ctx.ctrl.panel.tooltip.msResolution = false; ctx.ctrl.panel.tooltip.msResolution = false;
ctx.ctrl.onDataReceived(data); ctx.ctrl.onDataReceived(data);
...@@ -67,9 +67,9 @@ describe('GraphCtrl', function() { ...@@ -67,9 +67,9 @@ describe('GraphCtrl', function() {
describe('msResolution with millisecond resolution timestamps in one of the series', function() { describe('msResolution with millisecond resolution timestamps in one of the series', function() {
beforeEach(function() { beforeEach(function() {
var data = [ var data = [
{ target: 'test.cpu1', datapoints: [[1234567890000, 45], [1234567899000, 60]]}, { target: 'test.cpu1', datapoints: [[45, 1234567890000], [60, 1234567899000]]},
{ target: 'test.cpu2', datapoints: [[1236547890010, 55], [1234456709000, 90]]}, { target: 'test.cpu2', datapoints: [[55, 1236547890010], [90, 1234456709000]]},
{ target: 'test.cpu3', datapoints: [[1236547890000, 65], [1234456709000, 120]]} { target: 'test.cpu3', datapoints: [[65, 1236547890000], [120, 1234456709000]]}
]; ];
ctx.ctrl.panel.tooltip.msResolution = false; ctx.ctrl.panel.tooltip.msResolution = false;
ctx.ctrl.onDataReceived(data); ctx.ctrl.onDataReceived(data);
......
...@@ -56,7 +56,7 @@ define([ ...@@ -56,7 +56,7 @@ define([
}); });
}); });
describe('can detect if serie contains ms precision', function() { describe('can detect if series contains ms precision', function() {
var fakedata; var fakedata;
beforeEach(function() { beforeEach(function() {
...@@ -64,13 +64,13 @@ define([ ...@@ -64,13 +64,13 @@ define([
}); });
it('missing datapoint with ms precision', function() { it('missing datapoint with ms precision', function() {
fakedata.datapoints[0] = [1234567890000, 1337]; fakedata.datapoints[0] = [1337, 1234567890000];
series = new TimeSeries(fakedata); series = new TimeSeries(fakedata);
expect(series.isMsResolutionNeeded()).to.be(false); expect(series.isMsResolutionNeeded()).to.be(false);
}); });
it('contains datapoint with ms precision', function() { it('contains datapoint with ms precision', function() {
fakedata.datapoints[0] = [1236547890001, 1337]; fakedata.datapoints[0] = [1337, 1236547890001];
series = new TimeSeries(fakedata); series = new TimeSeries(fakedata);
expect(series.isMsResolutionNeeded()).to.be(true); expect(series.isMsResolutionNeeded()).to.be(true);
}); });
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment