Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
N
nexpie-grafana-theme
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Registry
Registry
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Kornkitt Poolsup
nexpie-grafana-theme
Commits
945b815f
Unverified
Commit
945b815f
authored
Oct 16, 2019
by
Andrej Ocenas
Committed by
GitHub
Oct 16, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix: Unsubscribe from events in dashboards (#19788)
* Unsubscribe on unmount * Fix unsubscribe
parent
f8c474fa
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
5 additions
and
0 deletions
+5
-0
public/app/features/dashboard/dashgrid/PanelChrome.tsx
+2
-0
public/app/features/dashboard/panel_editor/VisualizationTab.tsx
+3
-0
No files found.
public/app/features/dashboard/dashgrid/PanelChrome.tsx
View file @
945b815f
...
...
@@ -81,6 +81,8 @@ export class PanelChrome extends PureComponent<Props, State> {
componentWillUnmount
()
{
this
.
props
.
panel
.
events
.
off
(
PanelEvents
.
refresh
,
this
.
onRefresh
);
this
.
props
.
panel
.
events
.
off
(
PanelEvents
.
render
,
this
.
onRender
);
if
(
this
.
querySubscription
)
{
this
.
querySubscription
.
unsubscribe
();
this
.
querySubscription
=
null
;
...
...
public/app/features/dashboard/panel_editor/VisualizationTab.tsx
View file @
945b815f
...
...
@@ -151,6 +151,9 @@ export class VisualizationTab extends PureComponent<Props, State> {
}
componentWillUnmount
()
{
if
(
this
.
querySubscription
)
{
this
.
querySubscription
.
unsubscribe
();
}
this
.
cleanUpAngularOptions
();
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment