Fixed memory leak in bootstrap Typeahead code, Fixes #1497

src/app/directives/grafanaPanel.js

@@ -37,14 +37,6 @@ function (angular, $, config) {
           var getter = $parse(attr.type), panelType = getter($scope);
           var getter = $parse(attr.type), panelType = getter($scope);
           var newScope = $scope.$new();
           var newScope = $scope.$new();
 
 
-          $scope.kbnJqUiDraggableOptions = {
-            revert: 'invalid',
-            helper: function() {
-              return $('<div style="width:200px;height:100px;background: rgba(100,100,100,0.50);"/>');
-            },
-            placeholder: 'keep'
-          };
-
           // compile the module and uncloack. We're done
           // compile the module and uncloack. We're done
           function loadModule($module) {
           function loadModule($module) {
             $module.appendTo(elem);
             $module.appendTo(elem);

src/app/directives/templateParamSelector.js

@@ -75,6 +75,11 @@ function (angular, app, _, $) {
             $button.focus();
             $button.focus();
           });
           });
 
 
+          $scope.$on('$destroy', function() {
+            $button.unbind();
+            typeahead.destroy();
+          });
+
           $compile(elem.contents())($scope);
           $compile(elem.contents())($scope);
         }
         }
       };
       };

src/app/features/dashboard/dashboardCtrl.js

@@ -31,13 +31,6 @@ function (angular, $, config, _) {
       $scope.setupDashboard(dashboardData);
       $scope.setupDashboard(dashboardData);
     };
     };
 
 
-    $scope.registerWindowResizeEvent = function() {
-      angular.element(window).bind('resize', function() {
-        $timeout.cancel(resizeEventTimeout);
-        resizeEventTimeout = $timeout(function() { $scope.$broadcast('render'); }, 200);
-      });
-    };
-
     $scope.setupDashboard = function(dashboardData) {
     $scope.setupDashboard = function(dashboardData) {
       $rootScope.performance.dashboardLoadStart = new Date().getTime();
       $rootScope.performance.dashboardLoadStart = new Date().getTime();
       $rootScope.performance.panelsInitialized = 0;
       $rootScope.performance.panelsInitialized = 0;
@@ -127,5 +120,15 @@ function (angular, $, config, _) {
       $rootScope.$broadcast('render');
       $rootScope.$broadcast('render');
     };
     };
 
 
+    $scope.registerWindowResizeEvent = function() {
+      angular.element(window).bind('resize', function() {
+        $timeout.cancel(resizeEventTimeout);
+        resizeEventTimeout = $timeout(function() { $scope.$broadcast('render'); }, 200);
+      });
+      $scope.$on('$destroy', function() {
+        angular.element(window).unbind('resize');
+      });
+    };
+
   });
   });
 });
 });

src/vendor/bootstrap/bootstrap.js

@@ -2050,6 +2050,11 @@
         .on('click', $.proxy(this.click, this))
         .on('click', $.proxy(this.click, this))
         .on('mouseenter', 'li', $.proxy(this.mouseenter, this))
         .on('mouseenter', 'li', $.proxy(this.mouseenter, this))
         .on('mouseleave', 'li', $.proxy(this.mouseleave, this))
         .on('mouseleave', 'li', $.proxy(this.mouseleave, this))
+    },
+
+    destroy: function () {
+      this.$element.off().removeData('typeahead');
+      this.$menu.off();
     }
     }
 
 
   , eventSupported: function(eventName) {
   , eventSupported: function(eventName) {