Commit a96b522a by Torkel Ödegaard Committed by GitHub

Search: changed how search filter on current folder works (#17219)

parent cd9517c5
...@@ -60,17 +60,14 @@ export class DashNav extends PureComponent<Props> { ...@@ -60,17 +60,14 @@ export class DashNav extends PureComponent<Props> {
} }
} }
onOpenSearch = () => { onDahboardNameClick = () => {
const { dashboard } = this.props; appEvents.emit('show-dash-search');
const haveFolder = dashboard.meta.folderId > 0; };
appEvents.emit(
'show-dash-search', onFolderNameClick = () => {
haveFolder appEvents.emit('show-dash-search', {
? { query: 'folder:current',
query: 'folder:current', });
}
: null
);
}; };
onClose = () => { onClose = () => {
...@@ -148,11 +145,20 @@ export class DashNav extends PureComponent<Props> { ...@@ -148,11 +145,20 @@ export class DashNav extends PureComponent<Props> {
return ( return (
<> <>
<div> <div>
<a className="navbar-page-btn" onClick={this.onOpenSearch}> <div className="navbar-page-btn">
{!this.isInFullscreenOrSettings && <i className="gicon gicon-dashboard" />} {!this.isInFullscreenOrSettings && <i className="gicon gicon-dashboard" />}
{haveFolder && <span className="navbar-page-btn--folder">{folderTitle} / </span>} {haveFolder && (
{dashboard.title} <i className="fa fa-caret-down" /> <>
</a> <a className="navbar-page-btn__folder" onClick={this.onFolderNameClick}>
{folderTitle}
</a>
<i className="fa fa-chevron-right navbar-page-btn__folder-icon" />
</>
)}
<a onClick={this.onDahboardNameClick}>
{dashboard.title} <i className="fa fa-caret-down navbar-page-btn__search" />
</a>
</div>
</div> </div>
{this.isSettings && <span className="navbar-settings-title">&nbsp;/ Settings</span>} {this.isSettings && <span className="navbar-settings-title">&nbsp;/ Settings</span>}
<div className="navbar__spacer" /> <div className="navbar__spacer" />
......
...@@ -67,11 +67,6 @@ ...@@ -67,11 +67,6 @@
min-height: $navbarHeight; min-height: $navbarHeight;
line-height: $navbarHeight; line-height: $navbarHeight;
.fa-caret-down {
font-size: 60%;
padding-left: 6px;
}
.gicon { .gicon {
top: -2px; top: -2px;
position: relative; position: relative;
...@@ -85,17 +80,32 @@ ...@@ -85,17 +80,32 @@
display: inline-block; display: inline-block;
} }
} }
}
&--folder { .navbar-page-btn__folder {
color: $text-color-weak; color: $text-color-weak;
display: none; display: none;
@include media-breakpoint-up(lg) { @include media-breakpoint-up(lg) {
display: inline-block; display: inline-block;
}
} }
} }
// element is needed here to override font-awesome specificity
i.navbar-page-btn__folder-icon {
font-size: $font-size-sm;
color: $text-color-weak;
padding: 0 $space-sm;
position: relative;
top: -1px;
}
// element is needed here to override font-awesome specificity
i.navbar-page-btn__search {
font-size: $font-size-xs;
padding: 0 $space-xs;
}
.navbar-buttons { .navbar-buttons {
// height: $navbarHeight; // height: $navbarHeight;
display: flex; display: flex;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment