Api: Readonly datasources should not be created via the API (#19006)

* Readonly datasources should not be created via the API

* Return correct `ReadOnly` value in GetDataSourceByName

pkg/api/datasources.go

@@ -231,7 +231,6 @@ func GetDataSourceByName(c *m.ReqContext) Response {
 	}
 
 	dtos := convertModelToDtos(query.Result)
-	dtos.ReadOnly = true
 	return JSON(200, &dtos)
 }
 

pkg/models/datasource.go

@@ -144,9 +144,9 @@ type AddDataSourceCommand struct {
 	IsDefault         bool              `json:"isDefault"`
 	JsonData          *simplejson.Json  `json:"jsonData"`
 	SecureJsonData    map[string]string `json:"secureJsonData"`
-	ReadOnly          bool              `json:"readOnly"`
 
 	OrgId    int64 `json:"-"`
+	ReadOnly bool  `json:"-"`
 
 	Result *DataSource
 }
@@ -168,10 +168,10 @@ type UpdateDataSourceCommand struct {
 	JsonData          *simplejson.Json  `json:"jsonData"`
 	SecureJsonData    map[string]string `json:"secureJsonData"`
 	Version           int               `json:"version"`
-	ReadOnly          bool              `json:"readOnly"`
 
 	OrgId    int64 `json:"-"`
 	Id       int64 `json:"-"`
+	ReadOnly bool  `json:"-"`
 
 	Result *DataSource
 }