Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
N
nexpie-grafana-theme
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Registry
Registry
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Kornkitt Poolsup
nexpie-grafana-theme
Commits
b74e7629
Commit
b74e7629
authored
Oct 09, 2018
by
praveensastry
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
render drag handle only in edit mode
parent
c1fd2e55
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
1 deletions
+8
-1
public/app/features/dashboard/dashgrid/DashboardRow.tsx
+2
-1
public/app/features/dashboard/specs/DashboardRow.test.tsx
+6
-0
No files found.
public/app/features/dashboard/dashgrid/DashboardRow.tsx
View file @
b74e7629
...
...
@@ -87,6 +87,7 @@ export class DashboardRow extends React.Component<DashboardRowProps, any> {
const
title
=
templateSrv
.
replaceWithText
(
this
.
props
.
panel
.
title
,
this
.
props
.
panel
.
scopedVars
);
const
count
=
this
.
props
.
panel
.
panels
?
this
.
props
.
panel
.
panels
.
length
:
0
;
const
panels
=
count
===
1
?
'panel'
:
'panels'
;
const
editModeEnabled
=
this
.
dashboard
.
meta
.
canEdit
===
true
;
return
(
<
div
className=
{
classes
}
>
...
...
@@ -112,7 +113,7 @@ export class DashboardRow extends React.Component<DashboardRowProps, any> {
</
div
>
)
}
<
div
className=
"dashboard-row__drag grid-drag-handle"
/>
{
editModeEnabled
&&
<
div
className=
"dashboard-row__drag grid-drag-handle"
/>
}
</
div
>
);
}
...
...
public/app/features/dashboard/specs/DashboardRow.test.tsx
View file @
b74e7629
...
...
@@ -39,6 +39,12 @@ describe('DashboardRow', () => {
expect
(
wrapper
.
find
(
'.dashboard-row__actions .pointer'
)).
toHaveLength
(
2
);
});
it
(
'should not show row drag handle when cannot edit'
,
()
=>
{
dashboardMock
.
meta
.
canEdit
=
false
;
wrapper
=
shallow
(<
DashboardRow
panel=
{
panel
}
getPanelContainer=
{
getPanelContainer
}
/>);
expect
(
wrapper
.
find
(
'.dashboard-row__drag'
)).
toHaveLength
(
0
);
});
it
(
'should have zero actions when cannot edit'
,
()
=>
{
dashboardMock
.
meta
.
canEdit
=
false
;
panel
=
new
PanelModel
({
collapsed
:
false
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment