Commit b74e7629 by praveensastry

render drag handle only in edit mode

parent c1fd2e55
...@@ -87,6 +87,7 @@ export class DashboardRow extends React.Component<DashboardRowProps, any> { ...@@ -87,6 +87,7 @@ export class DashboardRow extends React.Component<DashboardRowProps, any> {
const title = templateSrv.replaceWithText(this.props.panel.title, this.props.panel.scopedVars); const title = templateSrv.replaceWithText(this.props.panel.title, this.props.panel.scopedVars);
const count = this.props.panel.panels ? this.props.panel.panels.length : 0; const count = this.props.panel.panels ? this.props.panel.panels.length : 0;
const panels = count === 1 ? 'panel' : 'panels'; const panels = count === 1 ? 'panel' : 'panels';
const editModeEnabled = this.dashboard.meta.canEdit === true;
return ( return (
<div className={classes}> <div className={classes}>
...@@ -112,7 +113,7 @@ export class DashboardRow extends React.Component<DashboardRowProps, any> { ...@@ -112,7 +113,7 @@ export class DashboardRow extends React.Component<DashboardRowProps, any> {
&nbsp; &nbsp;
</div> </div>
)} )}
<div className="dashboard-row__drag grid-drag-handle" /> {editModeEnabled && <div className="dashboard-row__drag grid-drag-handle" />}
</div> </div>
); );
} }
......
...@@ -39,6 +39,12 @@ describe('DashboardRow', () => { ...@@ -39,6 +39,12 @@ describe('DashboardRow', () => {
expect(wrapper.find('.dashboard-row__actions .pointer')).toHaveLength(2); expect(wrapper.find('.dashboard-row__actions .pointer')).toHaveLength(2);
}); });
it('should not show row drag handle when cannot edit', () => {
dashboardMock.meta.canEdit = false;
wrapper = shallow(<DashboardRow panel={panel} getPanelContainer={getPanelContainer} />);
expect(wrapper.find('.dashboard-row__drag')).toHaveLength(0);
});
it('should have zero actions when cannot edit', () => { it('should have zero actions when cannot edit', () => {
dashboardMock.meta.canEdit = false; dashboardMock.meta.canEdit = false;
panel = new PanelModel({ collapsed: false }); panel = new PanelModel({ collapsed: false });
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment