Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
N
nexpie-grafana-theme
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Registry
Registry
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Kornkitt Poolsup
nexpie-grafana-theme
Commits
be64af16
Commit
be64af16
authored
Sep 19, 2018
by
Jon Ferreira
Committed by
Jon Ferreira
Oct 09, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Block graph queries from being queued until annotation datasource promises resolve
parent
f37a60dc
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
16 additions
and
4 deletions
+16
-4
public/app/features/annotations/annotations_srv.ts
+7
-4
public/app/plugins/panel/graph/module.ts
+9
-0
No files found.
public/app/features/annotations/annotations_srv.ts
View file @
be64af16
...
...
@@ -8,6 +8,7 @@ import { makeRegions, dedupAnnotations } from './events_processing';
export
class
AnnotationsSrv
{
globalAnnotationsPromise
:
any
;
alertStatesPromise
:
any
;
datasourcePromises
:
any
;
/** @ngInject */
constructor
(
private
$rootScope
,
private
$q
,
private
datasourceSrv
,
private
backendSrv
,
private
timeSrv
)
{
...
...
@@ -18,6 +19,7 @@ export class AnnotationsSrv {
clearCache
()
{
this
.
globalAnnotationsPromise
=
null
;
this
.
alertStatesPromise
=
null
;
this
.
datasourcePromises
=
null
;
}
getAnnotations
(
options
)
{
...
...
@@ -90,6 +92,7 @@ export class AnnotationsSrv {
const
range
=
this
.
timeSrv
.
timeRange
();
const
promises
=
[];
const
dsPromises
=
[];
for
(
const
annotation
of
dashboard
.
annotations
.
list
)
{
if
(
!
annotation
.
enable
)
{
...
...
@@ -99,10 +102,10 @@ export class AnnotationsSrv {
if
(
annotation
.
snapshotData
)
{
return
this
.
translateQueryResult
(
annotation
,
annotation
.
snapshotData
);
}
const
datasourcePromise
=
this
.
datasourceSrv
.
get
(
annotation
.
datasource
);
dsPromises
.
push
(
datasourcePromise
);
promises
.
push
(
this
.
datasourceSrv
.
get
(
annotation
.
datasource
)
datasourcePromise
.
then
(
datasource
=>
{
// issue query against data source
return
datasource
.
annotationQuery
({
...
...
@@ -122,7 +125,7 @@ export class AnnotationsSrv {
})
);
}
this
.
datasourcePromises
=
this
.
$q
.
all
(
dsPromises
);
this
.
globalAnnotationsPromise
=
this
.
$q
.
all
(
promises
);
return
this
.
globalAnnotationsPromise
;
}
...
...
public/app/plugins/panel/graph/module.ts
View file @
be64af16
...
...
@@ -156,7 +156,16 @@ class GraphCtrl extends MetricsPanelCtrl {
panel
:
this
.
panel
,
range
:
this
.
range
,
});
/* Wait for annotationSrv requests to get datasources to
* resolve before issuing queries. This allows the annotations
* service to fire annotations queries before graph queries
* (but not wait for completion). This resolves
* issue 11806.
*/
return
this
.
annotationsSrv
.
datasourcePromises
.
then
(
r
=>
{
return
super
.
issueQueries
(
datasource
);
});
}
zoomOut
(
evt
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment