Merge branch 'cli_upgradeFix'

CHANGELOG.md

@@ -10,6 +10,7 @@
 * **Dashlist**: Fixed issue dashboard list panel and caching tags, fixes [#4768](https://github.com/grafana/grafana/issues/4768)
 * **Dashlist**: Fixed issue dashboard list panel and caching tags, fixes [#4768](https://github.com/grafana/grafana/issues/4768)
 * **Graph**: Fixed issue with unneeded scrollbar in legend for Firefox, fixes [#4760](https://github.com/grafana/grafana/issues/4760)
 * **Graph**: Fixed issue with unneeded scrollbar in legend for Firefox, fixes [#4760](https://github.com/grafana/grafana/issues/4760)
 * **Table panel**: Fixed issue table panel formating string array properties, fixes [#4791](https://github.com/grafana/grafana/issues/4791)
 * **Table panel**: Fixed issue table panel formating string array properties, fixes [#4791](https://github.com/grafana/grafana/issues/4791)
+* **grafana-cli**: Improve error message when failing to install plugins due to corrupt response, fixes [#4651](https://github.com/grafana/grafana/issues/4651)
 
 
 # 3.0.0-beta5 (2016-04-15)
 # 3.0.0-beta5 (2016-04-15)
 
 

pkg/cmd/grafana-cli/commands/commands.go

@@ -4,6 +4,7 @@ import (
 	"os"
 	"os"
 
 
 	"github.com/codegangsta/cli"
 	"github.com/codegangsta/cli"
+	"github.com/fatih/color"
 	"github.com/grafana/grafana/pkg/cmd/grafana-cli/log"
 	"github.com/grafana/grafana/pkg/cmd/grafana-cli/log"
 )
 )
 
 
@@ -12,7 +13,7 @@ func runCommand(command func(commandLine CommandLine) error) func(context *cli.C
 
 
 		cmd := &contextCommandLine{context}
 		cmd := &contextCommandLine{context}
 		if err := command(cmd); err != nil {
 		if err := command(cmd); err != nil {
-			log.Error("\nError: ")
+			log.Errorf("\n%s: ", color.RedString("Error"))
 			log.Errorf("%s\n\n", err)
 			log.Errorf("%s\n\n", err)
 
 
 			cmd.ShowHelp()
 			cmd.ShowHelp()

pkg/cmd/grafana-cli/commands/install_command.go

@@ -127,12 +127,17 @@ func downloadFile(pluginName, filePath, url string) (err error) {
 		if r := recover(); r != nil {
 		if r := recover(); r != nil {
 			retryCount++
 			retryCount++
 			if retryCount < 3 {
 			if retryCount < 3 {
-				fmt.Printf("\nFailed downloading. Will retry once.\n%v\n", r)
-				downloadFile(pluginName, filePath, url)
+				fmt.Println("Failed downloading. Will retry once.")
+				err = downloadFile(pluginName, filePath, url)
+			} else {
+				failure := fmt.Sprintf("%v", r)
+				if failure == "runtime error: makeslice: len out of range" {
+					err = fmt.Errorf("Corrupt http response from source. Please try again.\n")
 				} else {
 				} else {
 					panic(r)
 					panic(r)
 				}
 				}
 			}
 			}
+		}
 	}()
 	}()
 
 
 	resp, err := http.Get(url)
 	resp, err := http.Get(url)