teams: cleanup.

pkg/models/team_member.go

@@ -72,5 +72,5 @@ type TeamMemberDTO struct {
 	Login      string         `json:"login"`
 	Login      string         `json:"login"`
 	AvatarUrl  string         `json:"avatarUrl"`
 	AvatarUrl  string         `json:"avatarUrl"`
 	Labels     []string       `json:"labels"`
 	Labels     []string       `json:"labels"`
-	Permission int64    `json:"permission"`
+	Permission PermissionType `json:"permission"`
 }
 }

pkg/services/teamguardian/team.go

@@ -25,7 +25,7 @@ func CanAdmin(orgId int64, teamId int64, user *m.SignedInUser) error {
 	}
 	}
 
 
 	for _, member := range cmd.Result {
 	for _, member := range cmd.Result {
-		if member.UserId == user.UserId && member.Permission == int64(m.PERMISSION_ADMIN) {
+		if member.UserId == user.UserId && member.Permission == m.PERMISSION_ADMIN {
 			return nil
 			return nil
 		}
 		}
 	}
 	}

pkg/services/teamguardian/teams_test.go

@@ -45,7 +45,7 @@ func TestUpdateTeam(t *testing.T) {
 						OrgId:      testTeam.OrgId,
 						OrgId:      testTeam.OrgId,
 						TeamId:     testTeam.Id,
 						TeamId:     testTeam.Id,
 						UserId:     editor.UserId,
 						UserId:     editor.UserId,
-						Permission: int64(m.PERMISSION_ADMIN),
+						Permission: m.PERMISSION_ADMIN,
 					}}
 					}}
 					return nil
 					return nil
 				})
 				})
@@ -67,7 +67,7 @@ func TestUpdateTeam(t *testing.T) {
 						OrgId:      testTeamOtherOrg.OrgId,
 						OrgId:      testTeamOtherOrg.OrgId,
 						TeamId:     testTeamOtherOrg.Id,
 						TeamId:     testTeamOtherOrg.Id,
 						UserId:     editor.UserId,
 						UserId:     editor.UserId,
-						Permission: int64(m.PERMISSION_ADMIN),
+						Permission: m.PERMISSION_ADMIN,
 					}}
 					}}
 					return nil
 					return nil
 				})
 				})