Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
N
nexpie-grafana-theme
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Registry
Registry
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Kornkitt Poolsup
nexpie-grafana-theme
Commits
cf6736d4
Commit
cf6736d4
authored
Aug 12, 2016
by
bergquist
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix(metrics): add ending dot for graphite prefix
parent
41790c67
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
8 additions
and
7 deletions
+8
-7
conf/defaults.ini
+1
-1
conf/sample.ini
+1
-1
pkg/metrics/graphite.go
+1
-1
pkg/metrics/graphite_test.go
+5
-4
No files found.
conf/defaults.ini
View file @
cf6736d4
...
...
@@ -355,7 +355,7 @@ interval_seconds = 60
# Send internal Grafana metrics to graphite
; [metrics.graphite]
; address = localhost:2003
; prefix = service.grafana.%(instance_name)s
; prefix = service.grafana.%(instance_name)s
.
[grafana_net]
url
=
https://grafana.net
conf/sample.ini
View file @
cf6736d4
...
...
@@ -305,7 +305,7 @@ enabled = true
# Send internal metrics to Graphite
; [metrics.graphite]
; address = localhost:2003
; prefix = service.grafana.%(instance_name)s
; prefix = service.grafana.%(instance_name)s
.
#################################### Internal Grafana Metrics ##########################
# Url used to to import dashboards directly from Grafana.net
...
...
pkg/metrics/graphite.go
View file @
cf6736d4
...
...
@@ -33,7 +33,7 @@ func CreateGraphitePublisher() (*GraphitePublisher, error) {
prefix
:=
graphiteSection
.
Key
(
"prefix"
)
.
Value
()
if
prefix
==
""
{
prefix
=
"service.grafana.%(instance_name)s"
prefix
=
"service.grafana.%(instance_name)s
.
"
}
publisher
.
prefix
=
strings
.
Replace
(
prefix
,
"%(instance_name)s"
,
safeInstanceName
,
-
1
)
...
...
pkg/metrics/graphite_test.go
View file @
cf6736d4
...
...
@@ -19,8 +19,8 @@ func TestGraphitePublisher(t *testing.T) {
So
(
err
,
ShouldBeNil
)
sec
,
err
:=
setting
.
Cfg
.
NewSection
(
"metrics.graphite"
)
sec
.
NewKey
(
"prefix"
,
"service.grafana.%(instance_name)s"
)
sec
.
NewKey
(
"address"
,
"localhost:200
3
"
)
sec
.
NewKey
(
"prefix"
,
"service.grafana.%(instance_name)s
.
"
)
sec
.
NewKey
(
"address"
,
"localhost:200
1
"
)
So
(
err
,
ShouldBeNil
)
...
...
@@ -30,7 +30,8 @@ func TestGraphitePublisher(t *testing.T) {
So
(
err
,
ShouldBeNil
)
So
(
publisher
,
ShouldNotBeNil
)
So
(
publisher
.
prefix
,
ShouldEqual
,
"service.grafana.hostname_with_dots_com"
)
So
(
publisher
.
prefix
,
ShouldEqual
,
"service.grafana.hostname_with_dots_com."
)
So
(
publisher
.
address
,
ShouldEqual
,
"localhost:2001"
)
})
Convey
(
"Test graphite publisher default values"
,
t
,
func
()
{
...
...
@@ -49,7 +50,7 @@ func TestGraphitePublisher(t *testing.T) {
So
(
err
,
ShouldBeNil
)
So
(
publisher
,
ShouldNotBeNil
)
So
(
publisher
.
prefix
,
ShouldEqual
,
"service.grafana.hostname_with_dots_com"
)
So
(
publisher
.
prefix
,
ShouldEqual
,
"service.grafana.hostname_with_dots_com
.
"
)
So
(
publisher
.
address
,
ShouldEqual
,
"localhost:2003"
)
})
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment