Commit d3a3e7cf by Carl Bergquist Committed by GitHub

Merge pull request #12222 from PrincipalsOffice/remove-QueryOptionsCtrl-references

removed QueryOptionsCtrl references
parents 3b824a5e c9287487
...@@ -25,7 +25,6 @@ To interact with the rest of grafana the plugins module file can export 5 differ ...@@ -25,7 +25,6 @@ To interact with the rest of grafana the plugins module file can export 5 differ
- Datasource (Required) - Datasource (Required)
- QueryCtrl (Required) - QueryCtrl (Required)
- ConfigCtrl (Required) - ConfigCtrl (Required)
- QueryOptionsCtrl
- AnnotationsQueryCtrl - AnnotationsQueryCtrl
## Plugin json ## Plugin json
...@@ -182,12 +181,6 @@ A JavaScript class that will be instantiated and treated as an Angular controlle ...@@ -182,12 +181,6 @@ A JavaScript class that will be instantiated and treated as an Angular controlle
Requires a static template or templateUrl variable which will be rendered as the view for this controller. Requires a static template or templateUrl variable which will be rendered as the view for this controller.
## QueryOptionsCtrl
A JavaScript class that will be instantiated and treated as an Angular controller when the user edits metrics in a panel. This controller is responsible for handling panel wide settings for the datasource, such as interval, rate and aggregations if needed.
Requires a static template or templateUrl variable which will be rendered as the view for this controller.
## AnnotationsQueryCtrl ## AnnotationsQueryCtrl
A JavaScript class that will be instantiated and treated as an Angular controller when the user choose this type of datasource in the templating menu in the dashboard. A JavaScript class that will be instantiated and treated as an Angular controller when the user choose this type of datasource in the templating menu in the dashboard.
......
...@@ -126,24 +126,6 @@ function pluginDirectiveLoader($compile, datasourceSrv, $rootScope, $q, $http, $ ...@@ -126,24 +126,6 @@ function pluginDirectiveLoader($compile, datasourceSrv, $rootScope, $q, $http, $
}); });
}); });
} }
// QueryOptionsCtrl
case 'query-options-ctrl': {
return datasourceSrv.get(scope.ctrl.panel.datasource).then(ds => {
return importPluginModule(ds.meta.module).then((dsModule): any => {
if (!dsModule.QueryOptionsCtrl) {
return { notFound: true };
}
return {
baseUrl: ds.meta.baseUrl,
name: 'query-options-ctrl-' + ds.meta.id,
bindings: { panelCtrl: '=' },
attrs: { 'panel-ctrl': 'ctrl.panelCtrl' },
Component: dsModule.QueryOptionsCtrl,
};
});
});
}
// Annotations // Annotations
case 'annotations-query-ctrl': { case 'annotations-query-ctrl': {
return importPluginModule(scope.ctrl.currentDatasource.meta.module).then(function(dsModule) { return importPluginModule(scope.ctrl.currentDatasource.meta.module).then(function(dsModule) {
......
...@@ -2,10 +2,6 @@ import { ElasticDatasource } from './datasource'; ...@@ -2,10 +2,6 @@ import { ElasticDatasource } from './datasource';
import { ElasticQueryCtrl } from './query_ctrl'; import { ElasticQueryCtrl } from './query_ctrl';
import { ElasticConfigCtrl } from './config_ctrl'; import { ElasticConfigCtrl } from './config_ctrl';
class ElasticQueryOptionsCtrl {
static templateUrl = 'partials/query.options.html';
}
class ElasticAnnotationsQueryCtrl { class ElasticAnnotationsQueryCtrl {
static templateUrl = 'partials/annotations.editor.html'; static templateUrl = 'partials/annotations.editor.html';
} }
...@@ -14,6 +10,5 @@ export { ...@@ -14,6 +10,5 @@ export {
ElasticDatasource as Datasource, ElasticDatasource as Datasource,
ElasticQueryCtrl as QueryCtrl, ElasticQueryCtrl as QueryCtrl,
ElasticConfigCtrl as ConfigCtrl, ElasticConfigCtrl as ConfigCtrl,
ElasticQueryOptionsCtrl as QueryOptionsCtrl,
ElasticAnnotationsQueryCtrl as AnnotationsQueryCtrl, ElasticAnnotationsQueryCtrl as AnnotationsQueryCtrl,
}; };
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment