Chore: Configure go-ruleguard via golangci-lint (#28419)

* Chore: Configure go-ruleguard via golangci-lint

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>

pkg/services/oauthtoken/oauth_token_util.go

@@ -86,6 +86,6 @@ func IsOAuthPassThruEnabled(ds *models.DataSource) bool {
 func tokensEq(t1, t2 *oauth2.Token) bool {
 	return t1.AccessToken == t2.AccessToken &&
 		t1.RefreshToken == t2.RefreshToken &&
-		t1.Expiry == t2.Expiry &&
+		t1.Expiry.Equal(t2.Expiry) &&
 		t1.TokenType == t2.TokenType
 }

scripts/go/configs/.golangci.toml

@@ -11,6 +11,11 @@ min-occurrences = 5
 [linters-settings.exhaustive]
 default-signifies-exhaustive = true
 
+[linters-settings.gocritic]
+enabled-checks = ["ruleguard"]
+[linters-settings.gocritic.settings.ruleguard]
+rules = "pkg/ruleguard.rules.go"
+
 [linters]
 disable-all = true
 enable = [