cleanup

pkg/login/ext_user.go

@@ -117,8 +117,8 @@ func updateUser(user *m.User, extUser *m.ExternalUserInfo) error {
 }
 }
 
 
 func syncOrgRoles(user *m.User, extUser *m.ExternalUserInfo) error {
 func syncOrgRoles(user *m.User, extUser *m.ExternalUserInfo) error {
+	// don't sync org roles if none are specified
 	if len(extUser.OrgRoles) == 0 {
 	if len(extUser.OrgRoles) == 0 {
-		// log.Warn("No group mappings defined")
 		return nil
 		return nil
 	}
 	}
 
 

pkg/middleware/auth_proxy.go

@@ -68,6 +68,7 @@ func initContextWithAuthProxy(ctx *m.ReqContext, orgID int64) bool {
 			extUser.Login = proxyHeaderValue
 			extUser.Login = proxyHeaderValue
 		} else {
 		} else {
 			ctx.Handle(500, "Auth proxy header property invalid", nil)
 			ctx.Handle(500, "Auth proxy header property invalid", nil)
+			return true
 		}
 		}
 
 
 		// add/update user in grafana
 		// add/update user in grafana

pkg/services/sqlstore/user_auth.go

@@ -15,7 +15,7 @@ func init() {
 }
 }
 
 
 func GetUserByAuthInfo(query *m.GetUserByAuthInfoQuery) error {
 func GetUserByAuthInfo(query *m.GetUserByAuthInfoQuery) error {
-	user := new(m.User)
+	user := &m.User{}
 	has := false
 	has := false
 	var err error
 	var err error