Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
N
nexpie-grafana-theme
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Registry
Registry
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Kornkitt Poolsup
nexpie-grafana-theme
Commits
e8e1d353
Unverified
Commit
e8e1d353
authored
Jan 22, 2019
by
Torkel Ödegaard
Committed by
GitHub
Jan 22, 2019
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #14981 from grafana/hugoh/sidemenu-should-be-clickable
Added link to side menu header and fixed styling
parents
5446f49f
bf0333e3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
23 additions
and
11 deletions
+23
-11
public/app/core/components/sidemenu/SideMenuDropDown.tsx
+3
-1
public/app/core/components/sidemenu/__snapshots__/SideMenuDropDown.test.tsx.snap
+14
-10
public/sass/components/_sidemenu.scss
+6
-0
No files found.
public/app/core/components/sidemenu/SideMenuDropDown.tsx
View file @
e8e1d353
...
...
@@ -10,7 +10,9 @@ const SideMenuDropDown: FC<Props> = props => {
return
(
<
ul
className=
"dropdown-menu dropdown-menu--sidemenu"
role=
"menu"
>
<
li
className=
"side-menu-header"
>
<
span
className=
"sidemenu-item-text"
>
{
link
.
text
}
</
span
>
<
a
href=
{
link
.
url
}
>
<
span
className=
"sidemenu-item-text"
>
{
link
.
text
}
</
span
>
</
a
>
</
li
>
{
link
.
children
&&
link
.
children
.
map
((
child
,
index
)
=>
{
...
...
public/app/core/components/sidemenu/__snapshots__/SideMenuDropDown.test.tsx.snap
View file @
e8e1d353
...
...
@@ -8,11 +8,13 @@ exports[`Render should render children 1`] = `
<li
className="side-menu-header"
>
<span
className="sidemenu-item-text"
>
link
</span>
<a>
<span
className="sidemenu-item-text"
>
link
</span>
</a>
</li>
<DropDownChild
child={
...
...
@@ -49,11 +51,13 @@ exports[`Render should render component 1`] = `
<li
className="side-menu-header"
>
<span
className="sidemenu-item-text"
>
link
</span>
<a>
<span
className="sidemenu-item-text"
>
link
</span>
</a>
</li>
</ul>
`;
public/sass/components/_sidemenu.scss
View file @
e8e1d353
...
...
@@ -149,6 +149,12 @@
color
:
#ebedf2
;
}
.side-menu-header
>
a
{
// Removes left-brand-border-gradient from link
border
:
none
!
important
;
padding
:
0
!
important
;
}
.sidemenu-subtitle
{
padding
:
0
.5rem
1rem
0
.5rem
;
font-size
:
$font-size-sm
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment