no unbound recursion in publish()

unbound recursion approach can blow up call stack,
and - I think - allocate memory unboundedly as well.

We can simply loop until err != nil

I didn't actually test this live, though tests succeed

pkg/services/eventpublisher/eventpublisher.go

@@ -109,6 +109,7 @@ func Setup() error {
 }
 
 func publish(routingKey string, msgString []byte) {
+	for {
 		err := channel.Publish(
 			exchange,   //exchange
 			routingKey, // routing key
@@ -119,15 +120,15 @@ func publish(routingKey string, msgString []byte) {
 				Body:        msgString,
 			},
 		)
-	if err != nil {
+		if err == nil {
+			return
+		}
 		// failures are most likely because the connection was lost.
 		// the connection will be re-established, so just keep
 		// retrying every 2seconds until we successfully publish.
 		time.Sleep(2 * time.Second)
 		fmt.Println("publish failed, retrying.")
-		publish(routingKey, msgString)
 	}
-	return
 }
 
 func eventListener(event interface{}) error {