Commit ef0bf9f7 by Augustin Committed by Torkel Ödegaard

ensure that if the dasboardID is negative, it will not bypass the checking of the right (#12398)

parent 5a2cf586
...@@ -272,9 +272,9 @@ func canSaveByDashboardID(c *m.ReqContext, dashboardID int64) (bool, error) { ...@@ -272,9 +272,9 @@ func canSaveByDashboardID(c *m.ReqContext, dashboardID int64) (bool, error) {
return false, nil return false, nil
} }
if dashboardID > 0 { if dashboardID != 0 {
guardian := guardian.New(dashboardID, c.OrgId, c.SignedInUser) guard := guardian.New(dashboardID, c.OrgId, c.SignedInUser)
if canEdit, err := guardian.CanEdit(); err != nil || !canEdit { if canEdit, err := guard.CanEdit(); err != nil || !canEdit {
return false, err return false, err
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment