query.go
4.22 KB
-
Use parenthesis to surround the selected tags for influxdb queries (#9131) · bdfbc245
The generated queries when selecting multiple tags are incorrect. In InfluxQL, `AND` has a higher precedence than `OR` so the condition: WHERE "hostname" = 'server1' OR "hostname" = 'server2' AND time > now() - 5m This is parsed as if it were: WHERE "hostname" = 'server1' OR ("hostname" = 'server2' AND time > now() - 5m) But the intention is to write a query like this: WHERE ("hostname" = 'server1' OR "hostname" = 'server2') AND time > now() - 5m This change modifies the generated query so it surrounds a query with multiple conditions in parenthesis so it doesn't conflict with the time expression in an unexpected way. This is currently not an issue because InfluxDB doesn't actually evaluate the condition for the time expression correctly. It just looks through the AST for anything that looks like a time expression and then assumes the proper format of `AND` was used rather than validating that it was used correctly.
Jonathan A. Sternberg committed