Commit 0ff5ff5d by utkarshcmu

Enabled refresh interval for absolute time range

parent 85382dc2
...@@ -93,12 +93,7 @@ define([ ...@@ -93,12 +93,7 @@ define([
this.setTime = function(time) { this.setTime = function(time) {
_.extend(this.time, time); _.extend(this.time, time);
// disable refresh if we have an absolute time if (this.old_refresh && this.old_refresh !== this.dashboard.refresh) {
if (moment.isMoment(time.to)) {
this.old_refresh = this.dashboard.refresh || this.old_refresh;
this.setAutoRefresh(false);
}
else if (this.old_refresh && this.old_refresh !== this.dashboard.refresh) {
this.setAutoRefresh(this.old_refresh); this.setAutoRefresh(this.old_refresh);
this.old_refresh = null; this.old_refresh = null;
} }
......
...@@ -78,17 +78,24 @@ define([ ...@@ -78,17 +78,24 @@ define([
}); });
describe('setTime', function() { describe('setTime', function() {
it('should return disable refresh for absolute times', function() { it('should return disable refresh if refresh is disabled for any range', function() {
_dashboard.refresh = false; _dashboard.refresh = false;
ctx.service.setTime({from: '2011-01-01', to: '2015-01-01' }); ctx.service.setTime({from: '2011-01-01', to: '2015-01-01' });
expect(_dashboard.refresh).to.be(false); expect(_dashboard.refresh).to.be(false);
}); });
it('should restore refresh for absolute time range', function() {
_dashboard.refresh = '30s';
ctx.service.setTime({from: '2011-01-01', to: '2015-01-01' });
expect(_dashboard.refresh).to.be('30s');
});
it('should restore refresh after relative time range is set', function() { it('should restore refresh after relative time range is set', function() {
_dashboard.refresh = '10s'; _dashboard.refresh = '10s';
ctx.service.setTime({from: moment([2011,1,1]), to: moment([2015,1,1])}); ctx.service.setTime({from: moment([2011,1,1]), to: moment([2015,1,1])});
expect(_dashboard.refresh).to.be(false); expect(_dashboard.refresh).to.be('10s');
ctx.service.setTime({from: '2011-01-01', to: 'now' }); ctx.service.setTime({from: '2011-01-01', to: 'now' });
expect(_dashboard.refresh).to.be('10s'); expect(_dashboard.refresh).to.be('10s');
}); });
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment