Merge PR #15868 password hint

conf/defaults.ini

@@ -231,6 +231,7 @@ verify_email_enabled = false
 
 
 # Background text for the user field on the login page
 # Background text for the user field on the login page
 login_hint = email or username
 login_hint = email or username
+password_hint = password
 
 
 # Default UI theme ("dark" or "light")
 # Default UI theme ("dark" or "light")
 default_theme = dark
 default_theme = dark

conf/sample.ini

@@ -211,6 +211,7 @@ log_queries =
 
 
 # Background text for the user field on the login page
 # Background text for the user field on the login page
 ;login_hint = email or username
 ;login_hint = email or username
+;password_hint = password
 
 
 # Default UI theme ("dark" or "light")
 # Default UI theme ("dark" or "light")
 ;default_theme = dark
 ;default_theme = dark

docs/sources/installation/configuration.md

@@ -162,9 +162,9 @@ executed with working directory set to the installation path.
 
 
 ### enable_gzip
 ### enable_gzip
 
 
-Set this option to `true` to enable HTTP compression, this can improve 
-transfer speed and bandwidth utilization. It is recommended that most 
-users set it to `true`. By default it is set to `false` for compatibility 
+Set this option to `true` to enable HTTP compression, this can improve
+transfer speed and bandwidth utilization. It is recommended that most
+users set it to `true`. By default it is set to `false` for compatibility
 reasons.
 reasons.
 
 
 ### cert_file
 ### cert_file
@@ -342,6 +342,14 @@ options are `Admin` and `Editor`. e.g. :
 Viewers can edit/inspect dashboard settings in the browser. But not save the dashboard.
 Viewers can edit/inspect dashboard settings in the browser. But not save the dashboard.
 Defaults to `false`.
 Defaults to `false`.
 
 
+### login_hint
+
+Text used as placeholder text on login page for login/username input.
+
+### password_hint
+
+Text used as placeholder text on login page for password input.
+
 <hr>
 <hr>
 
 
 ## [auth]
 ## [auth]

pkg/api/login.go

@@ -36,6 +36,7 @@ func (hs *HTTPServer) LoginView(c *m.ReqContext) {
 	viewData.Settings["oauth"] = enabledOAuths
 	viewData.Settings["oauth"] = enabledOAuths
 	viewData.Settings["disableUserSignUp"] = !setting.AllowUserSignUp
 	viewData.Settings["disableUserSignUp"] = !setting.AllowUserSignUp
 	viewData.Settings["loginHint"] = setting.LoginHint
 	viewData.Settings["loginHint"] = setting.LoginHint
+	viewData.Settings["passwordHint"] = setting.PasswordHint
 	viewData.Settings["disableLoginForm"] = setting.DisableLoginForm
 	viewData.Settings["disableLoginForm"] = setting.DisableLoginForm
 
 
 	if loginError, ok := tryGetEncryptedCookie(c, LoginErrorCookieName); ok {
 	if loginError, ok := tryGetEncryptedCookie(c, LoginErrorCookieName); ok {

pkg/setting/setting.go

@@ -109,6 +109,7 @@ var (
 	AutoAssignOrgRole       string
 	AutoAssignOrgRole       string
 	VerifyEmailEnabled      bool
 	VerifyEmailEnabled      bool
 	LoginHint               string
 	LoginHint               string
+	PasswordHint            string
 	DefaultTheme            string
 	DefaultTheme            string
 	DisableLoginForm        bool
 	DisableLoginForm        bool
 	DisableSignoutMenu      bool
 	DisableSignoutMenu      bool
@@ -656,6 +657,7 @@ func (cfg *Cfg) Load(args *CommandLineArgs) error {
 	AutoAssignOrgRole = users.Key("auto_assign_org_role").In("Editor", []string{"Editor", "Admin", "Viewer"})
 	AutoAssignOrgRole = users.Key("auto_assign_org_role").In("Editor", []string{"Editor", "Admin", "Viewer"})
 	VerifyEmailEnabled = users.Key("verify_email_enabled").MustBool(false)
 	VerifyEmailEnabled = users.Key("verify_email_enabled").MustBool(false)
 	LoginHint = users.Key("login_hint").String()
 	LoginHint = users.Key("login_hint").String()
+	PasswordHint = users.Key("password_hint").String()
 	DefaultTheme = users.Key("default_theme").String()
 	DefaultTheme = users.Key("default_theme").String()
 	ExternalUserMngLinkUrl = users.Key("external_manage_link_url").String()
 	ExternalUserMngLinkUrl = users.Key("external_manage_link_url").String()
 	ExternalUserMngLinkName = users.Key("external_manage_link_name").String()
 	ExternalUserMngLinkName = users.Key("external_manage_link_name").String()

public/app/core/config.ts

@@ -34,6 +34,7 @@ export class Settings {
   oauth: any;
   oauth: any;
   disableUserSignUp: boolean;
   disableUserSignUp: boolean;
   loginHint: any;
   loginHint: any;
+  passwordHint: any;
   loginError: any;
   loginError: any;
   viewersCanEdit: boolean;
   viewersCanEdit: boolean;
   editorsCanOwn: boolean;
   editorsCanOwn: boolean;

public/app/core/controllers/login_ctrl.ts

@@ -25,6 +25,7 @@ export class LoginCtrl {
     $scope.disableLoginForm = config.disableLoginForm;
     $scope.disableLoginForm = config.disableLoginForm;
     $scope.disableUserSignUp = config.disableUserSignUp;
     $scope.disableUserSignUp = config.disableUserSignUp;
     $scope.loginHint = config.loginHint;
     $scope.loginHint = config.loginHint;
+    $scope.passwordHint = config.passwordHint;
 
 
     $scope.loginMode = true;
     $scope.loginMode = true;
     $scope.submitBtnText = 'Log in';
     $scope.submitBtnText = 'Log in';

public/app/partials/login.html

@@ -13,7 +13,7 @@
           </div>
           </div>
           <div class="login-form">
           <div class="login-form">
             <input type="password" name="password" class="gf-form-input login-form-input" required ng-model="formModel.password" id="inputPassword"
             <input type="password" name="password" class="gf-form-input login-form-input" required ng-model="formModel.password" id="inputPassword"
-              placeholder="password">
+              placeholder="{{passwordHint}}">
           </div>
           </div>
           <div class="login-button-group">
           <div class="login-button-group">
             <button type="submit" class="btn btn-large p-x-2" ng-if="!loggingIn" ng-click="submit();" ng-class="{'btn-inverse': !loginForm.$valid, 'btn-primary': loginForm.$valid}">
             <button type="submit" class="btn btn-large p-x-2" ng-if="!loggingIn" ng-click="submit();" ng-class="{'btn-inverse': !loginForm.$valid, 'btn-primary': loginForm.$valid}">