Fixes to edit view switching, and to templateValuesSrv

src/app/directives/dashEditLink.js

@@ -107,7 +107,9 @@ function (angular, $) {
               showEditorPane(null, {}, newValue);
               showEditorPane(null, {}, newValue);
             } else if (oldValue) {
             } else if (oldValue) {
               scope.contextSrv.editview = null;
               scope.contextSrv.editview = null;
-              hideEditorPane();
+              if (lastEditor === editViewMap[oldValue]) {
+                hideEditorPane();
+              }
             }
             }
           });
           });
 
 

src/app/features/annotations/annotationsSrv.js

@@ -12,6 +12,7 @@ define([
     var promiseCached;
     var promiseCached;
     var list = [];
     var list = [];
     var timezone;
     var timezone;
+    var self = this;
 
 
     this.init = function() {
     this.init = function() {
       $rootScope.onAppEvent('refresh', this.clearCache);
       $rootScope.onAppEvent('refresh', this.clearCache);
@@ -33,15 +34,15 @@ define([
       }
       }
 
 
       timezone = dashboard.timezone;
       timezone = dashboard.timezone;
-      var annotations = _.where(dashboard.annotations.list, { enable: true });
+      var annotations = _.where(dashboard.annotations.list, {enable: true});
 
 
       var promises  = _.map(annotations, function(annotation) {
       var promises  = _.map(annotations, function(annotation) {
-        var datasource = datasourceSrv.get(annotation.datasource);
-
-        return datasource.annotationQuery(annotation, rangeUnparsed)
-          .then(this.receiveAnnotationResults)
-          .then(null, errorHandler);
-      }, this);
+        return datasourceSrv.get(annotation.datasource).then(function(datasource) {
+          return datasource.annotationQuery(annotation, rangeUnparsed)
+            .then(self.receiveAnnotationResults)
+            .then(null, errorHandler);
+        }, this);
+      });
 
 
       promiseCached = $q.all(promises)
       promiseCached = $q.all(promises)
         .then(function() {
         .then(function() {

src/app/features/templating/templateValuesSrv.js

@@ -97,9 +97,8 @@ function (angular, _, kbn) {
         return $q.when([]);
         return $q.when([]);
       }
       }
 
 
-      var datasource = datasourceSrv.get(variable.datasource);
-      return datasource.metricFindQuery(variable.query)
-        .then(function (results) {
+      return datasourceSrv.get(variable.datasource).then(function(datasource) {
+        return datasource.metricFindQuery(variable.query).then(function (results) {
           variable.options = self.metricNamesToVariableValues(variable, results);
           variable.options = self.metricNamesToVariableValues(variable, results);
 
 
           if (variable.includeAll) {
           if (variable.includeAll) {
@@ -117,6 +116,7 @@ function (angular, _, kbn) {
 
 
           return self.setVariableValue(variable, variable.options[0], true);
           return self.setVariableValue(variable, variable.options[0], true);
         });
         });
+      });
     };
     };
 
 
     this.metricNamesToVariableValues = function(variable, metricNames) {
     this.metricNamesToVariableValues = function(variable, metricNames) {
@@ -149,19 +149,19 @@ function (angular, _, kbn) {
     this.addAllOption = function(variable) {
     this.addAllOption = function(variable) {
       var allValue = '';
       var allValue = '';
       switch(variable.allFormat) {
       switch(variable.allFormat) {
-      case 'wildcard':
-        allValue = '*';
-        break;
-      case 'regex wildcard':
-        allValue = '.*';
-        break;
-      case 'regex values':
-        allValue = '(' + _.pluck(variable.options, 'text').join('|') + ')';
-        break;
-      default:
-        allValue = '{';
-        allValue += _.pluck(variable.options, 'text').join(',');
-        allValue += '}';
+        case 'wildcard':
+          allValue = '*';
+          break;
+        case 'regex wildcard':
+          allValue = '.*';
+          break;
+        case 'regex values':
+          allValue = '(' + _.pluck(variable.options, 'text').join('|') + ')';
+          break;
+        default:
+          allValue = '{';
+          allValue += _.pluck(variable.options, 'text').join(',');
+          allValue += '}';
       }
       }
 
 
       variable.options.unshift({text: 'All', value: allValue});
       variable.options.unshift({text: 'All', value: allValue});