Merge pull request #11648 from mjtrangoni/add-gometalinter-circleci

Add gometalinter to CircleCI

.circleci/config.yml

@@ -17,6 +17,22 @@ jobs:
           name: check documentation spelling errors
           name: check documentation spelling errors
           command: 'codespell -I ./words_to_ignore.txt docs/'
           command: 'codespell -I ./words_to_ignore.txt docs/'
 
 
+  gometalinter:
+    docker:
+      - image: circleci/golang:1.10
+    working_directory: /go/src/github.com/grafana/grafana
+    steps:
+      - checkout
+      - run:
+          name: install gometalinter tool
+          command: 'go get -u github.com/alecthomas/gometalinter'
+      - run:
+          name: install linters
+          command: 'gometalinter --install'
+      - run:
+          name: run some linters
+          command: 'gometalinter --vendor --deadline 6m --disable-all --enable=structcheck --enable=unconvert --enable=varcheck ./...'
+
   test-frontend:
   test-frontend:
     docker:
     docker:
       - image: circleci/node:6.11.4
       - image: circleci/node:6.11.4
@@ -123,6 +139,10 @@ workflows:
           filters:
           filters:
             tags:
             tags:
               only: /.*/
               only: /.*/
+      - gometalinter:
+          filters:
+            tags:
+              only: /.*/
       - build:
       - build:
           filters:
           filters:
             tags:
             tags:

pkg/services/alerting/engine.go

@@ -15,8 +15,8 @@ import (
 )
 )
 
 
 type Engine struct {
 type Engine struct {
-	execQueue     chan *Job
-	clock         clock.Clock
+	execQueue chan *Job
+	//clock         clock.Clock
 	ticker        *Ticker
 	ticker        *Ticker
 	scheduler     Scheduler
 	scheduler     Scheduler
 	evalHandler   EvalHandler
 	evalHandler   EvalHandler

pkg/services/alerting/reader.go

@@ -16,7 +16,7 @@ type RuleReader interface {
 
 
 type DefaultRuleReader struct {
 type DefaultRuleReader struct {
 	sync.RWMutex
 	sync.RWMutex
-	serverID       string
+	//serverID       string
 	serverPosition int
 	serverPosition int
 	clusterSize    int
 	clusterSize    int
 	log            log.Logger
 	log            log.Logger

pkg/services/sqlstore/migrator/migrations.go

@@ -179,7 +179,7 @@ type CopyTableDataMigration struct {
 	targetTable string
 	targetTable string
 	sourceCols  []string
 	sourceCols  []string
 	targetCols  []string
 	targetCols  []string
-	colMap      map[string]string
+	//colMap      map[string]string
 }
 }
 
 
 func NewCopyTableDataMigration(targetTable string, sourceTable string, colMap map[string]string) *CopyTableDataMigration {
 func NewCopyTableDataMigration(targetTable string, sourceTable string, colMap map[string]string) *CopyTableDataMigration {