DashboardImport: Fix variable interpolation when property contains multiple…

DashboardImport: Fix variable interpolation when property contains multiple variable expressions (#26574)

pkg/plugins/dashboard_importer.go

@@ -11,7 +11,7 @@ import (
 	"github.com/grafana/grafana/pkg/services/dashboards"
 	"github.com/grafana/grafana/pkg/services/dashboards"
 )
 )
 
 
-var varRegex = regexp.MustCompile(`(\$\{.+\})`)
+var varRegex = regexp.MustCompile(`(\$\{.+?\})`)
 
 
 type ImportDashboardCommand struct {
 type ImportDashboardCommand struct {
 	Dashboard *simplejson.Json
 	Dashboard *simplejson.Json

pkg/plugins/dashboard_importer_test.go

@@ -58,7 +58,7 @@ func TestDashboardImport(t *testing.T) {
 			}
 			}
 		],
 		],
 		"test": {
 		"test": {
-			"prop": "${DS_NAME}"
+			"prop": "${DS_NAME}_${DS_NAME}"
 		}
 		}
 		}`))
 		}`))
 
 
@@ -73,7 +73,7 @@ func TestDashboardImport(t *testing.T) {
 		So(err, ShouldBeNil)
 		So(err, ShouldBeNil)
 
 
 		Convey("should render template", func() {
 		Convey("should render template", func() {
-			So(res.GetPath("test", "prop").MustString(), ShouldEqual, "my-server")
+			So(res.GetPath("test", "prop").MustString(), ShouldEqual, "my-server_my-server")
 		})
 		})
 
 
 		Convey("should not include inputs in output", func() {
 		Convey("should not include inputs in output", func() {