Docs: Update release guide (#17759)

and add comment about Rollup namedExports

packages/grafana-ui/README.md

@@ -17,31 +17,35 @@ See [package source](https://github.com/grafana/grafana/tree/master/packages/gra
 For development purposes we suggest using `yarn link` that will create symlink to @grafana/ui lib. To do so navigate to `packages/grafana-ui` and run `yarn link`. Then, navigate to your project and run `yarn link @grafana/ui` to use the linked version of the lib. To unlink follow the same procedure, but use `yarn unlink` instead.
 For development purposes we suggest using `yarn link` that will create symlink to @grafana/ui lib. To do so navigate to `packages/grafana-ui` and run `yarn link`. Then, navigate to your project and run `yarn link @grafana/ui` to use the linked version of the lib. To unlink follow the same procedure, but use `yarn unlink` instead.
 
 
 ## Building @grafana/ui
 ## Building @grafana/ui
-To build @grafana/ui run `npm run gui:build` script *from Grafana repository root*. The build will be created in `packages/grafana-ui/dist` directory. Following steps from [Development](#development) you can test built package.
+
+To build @grafana/ui run `npm run gui:build` script _from Grafana repository root_. The build will be created in `packages/grafana-ui/dist` directory. Following steps from [Development](#development) you can test built package.
 
 
 ## Releasing new version
 ## Releasing new version
-To release new version run `npm run gui:release` script *from Grafana repository root*. The script will prepare the distribution package as well as prompt you to bump library version and publish it to the NPM registry.
+
+To release new version run `npm run gui:release` script _from Grafana repository root_. This has to be done on the master branch. The script will prepare the distribution package as well as prompt you to bump library version and publish it to the NPM registry. When the new package is published, create a PR with the bumped version in package.json.
 
 
 ### Automatic version bump
 ### Automatic version bump
+
 When running `npm run gui:release` package.json file will be automatically updated. Also, package.json file will be commited and pushed to upstream branch.
 When running `npm run gui:release` package.json file will be automatically updated. Also, package.json file will be commited and pushed to upstream branch.
 
 
 ### Manual version bump
 ### Manual version bump
-To use `package.json` defined version run `npm run gui:release --usePackageJsonVersion` *from Grafana repository root*.
+
+Manually update the version in `package.json` and then run `npm run gui:release --usePackageJsonVersion` _from Grafana repository root_.
 
 
 ### Preparing release package without publishing to NPM registry
 ### Preparing release package without publishing to NPM registry
+
 For testing purposes there is `npm run gui:releasePrepare` task that prepares distribution package without publishing it to the NPM registry.
 For testing purposes there is `npm run gui:releasePrepare` task that prepares distribution package without publishing it to the NPM registry.
 
 
 ### V1 release process overview
 ### V1 release process overview
+
 1. Package is compiled with TSC. Typings are created in `/dist` directory, and the compiled js lands in `/compiled` dir
 1. Package is compiled with TSC. Typings are created in `/dist` directory, and the compiled js lands in `/compiled` dir
 2. Rollup creates a CommonJS package based on compiled sources, and outputs it to `/dist` directory
 2. Rollup creates a CommonJS package based on compiled sources, and outputs it to `/dist` directory
 3. Readme, changelog and index.js files are moved to `/dist` directory
 3. Readme, changelog and index.js files are moved to `/dist` directory
 4. Package version is bumped in both `@grafana/ui` package dir and in dist directory.
 4. Package version is bumped in both `@grafana/ui` package dir and in dist directory.
 5. Version commit is created and pushed to master branch
 5. Version commit is created and pushed to master branch
-5. Package is published to npm
-
+6. Package is published to npm
 
 
 ## Versioning
 ## Versioning
+
 To limit the confusion related to @grafana/ui and Grafana versioning we decided to keep the major version in sync between those two.
 To limit the confusion related to @grafana/ui and Grafana versioning we decided to keep the major version in sync between those two.
 This means, that first version of @grafana/ui is taged with 6.0.0-alpha.0 to keep version in sync with Grafana 6.0 release.
 This means, that first version of @grafana/ui is taged with 6.0.0-alpha.0 to keep version in sync with Grafana 6.0 release.
-
-

packages/grafana-ui/rollup.config.ts

@@ -27,6 +27,8 @@ const buildCjsPackage = ({ env }) => {
     plugins: [
     plugins: [
       commonjs({
       commonjs({
         include: /node_modules/,
         include: /node_modules/,
+        // When 'rollup-plugin-commonjs' fails to properly convert the CommonJS modules to ES6 one has to manually name the exports
+        // https://github.com/rollup/rollup-plugin-commonjs#custom-named-exports
         namedExports: {
         namedExports: {
           '../../node_modules/lodash/lodash.js': [
           '../../node_modules/lodash/lodash.js': [
             'flatten',
             'flatten',