Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
N
nexpie-grafana-theme
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Registry
Registry
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Kornkitt Poolsup
nexpie-grafana-theme
Commits
6d6c7698
Unverified
Commit
6d6c7698
authored
Mar 08, 2019
by
Torkel Ödegaard
Committed by
GitHub
Mar 08, 2019
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #15881 from zhulongcheng/docs-Contributing
docs: update CONTRIBUTING.md
parents
57018738
e08d8eb5
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
5 deletions
+4
-5
CONTRIBUTING.md
+4
-5
No files found.
CONTRIBUTING.md
View file @
6d6c7698
...
@@ -34,10 +34,10 @@ To setup a local development environment we recommend reading [Building Grafana
...
@@ -34,10 +34,10 @@ To setup a local development environment we recommend reading [Building Grafana
### Pull requests with new features
### Pull requests with new features
Commits should be as small as possible, while ensuring that each commit is correct independently (i.e., each commit should compile and pass tests).
Commits should be as small as possible, while ensuring that each commit is correct independently (i.e., each commit should compile and pass tests).
Make sure to include
`
closes #<issue>`
or
`fixes #<issue
>`
in the pull request description.
Make sure to include
`
Closes #<issue number>`
or
`Fixes #<issue number
>`
in the pull request description.
### Pull requests with bug fixes
### Pull requests with bug fixes
Please make all changes in one commit if possible. Include
`
closes #12345
`
in bottom of the commit message.
Please make all changes in one commit if possible. Include
`
Closes #<issue number>
`
in bottom of the commit message.
A commit message for a bug fix should look something like this.
A commit message for a bug fix should look something like this.
```
```
...
@@ -48,7 +48,7 @@ provsioners each provisioner overwrite each other.
...
@@ -48,7 +48,7 @@ provsioners each provisioner overwrite each other.
filling up dashboard_versions quite fast if using
filling up dashboard_versions quite fast if using
default settings.
default settings.
c
loses #12864
C
loses #12864
```
```
If the pull request needs changes before its merged the new commits should be rebased into one commit before its merged.
If the pull request needs changes before its merged the new commits should be rebased into one commit before its merged.
\ No newline at end of file
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment