Commit 705455d5 by Torkel Ödegaard

Set active account now works again

parent 973b9cad
...@@ -22,6 +22,7 @@ func Register(m *macaron.Macaron) { ...@@ -22,6 +22,7 @@ func Register(m *macaron.Macaron) {
m.Get("/account/", auth, Index) m.Get("/account/", auth, Index)
m.Get("/api/account/", auth, GetAccount) m.Get("/api/account/", auth, GetAccount)
m.Post("/api/account/collaborators/add", auth, AddCollaborator) m.Post("/api/account/collaborators/add", auth, AddCollaborator)
m.Post("/api/account/using/:id", auth, SetUsingAccount)
m.Get("/api/account/others", auth, GetOtherAccounts) m.Get("/api/account/others", auth, GetOtherAccounts)
// user register // user register
......
package api package api
import ( import (
"github.com/gin-gonic/gin"
"github.com/torkelo/grafana-pro/pkg/api/dtos" "github.com/torkelo/grafana-pro/pkg/api/dtos"
"github.com/torkelo/grafana-pro/pkg/middleware" "github.com/torkelo/grafana-pro/pkg/middleware"
"github.com/torkelo/grafana-pro/pkg/models" "github.com/torkelo/grafana-pro/pkg/models"
...@@ -88,28 +89,36 @@ func GetOtherAccounts(c *middleware.Context) { ...@@ -88,28 +89,36 @@ func GetOtherAccounts(c *middleware.Context) {
c.JSON(200, result) c.JSON(200, result)
} }
// func SetUsingAccount(c *middleware.Context) { func SetUsingAccount(c *middleware.Context) {
// idString := c.Params.ByName("id") usingAccountId := c.ParamsInt64(":id")
// id, _ := strconv.Atoi(idString)
// account := c.UserAccount
// account := auth.userAccount otherAccounts, err := models.GetOtherAccountsFor(c.UserAccount.Id)
// otherAccount, err := self.store.GetAccount(id)
// if err != nil { if err != nil {
// c.JSON(500, gin.H{"message": err.Error()}) c.JSON(500, gin.H{"message": err.Error()})
// return return
// } }
//
// if otherAccount.Id != account.Id && !otherAccount.HasCollaborator(account.Id) { // validate that the account id in the list
// c.Abort(401) valid := false
// return for _, other := range otherAccounts {
// } if other.Id == usingAccountId {
// valid = true
// account.UsingAccountId = otherAccount.Id }
// err = self.store.UpdateAccount(account) }
// if err != nil {
// c.JSON(500, gin.H{"message": err.Error()}) if !valid {
// return c.Status(401)
// } return
// }
// c.Abort(204)
// } account.UsingAccountId = usingAccountId
err = models.SaveAccount(account)
if err != nil {
c.JSON(500, gin.H{"message": err.Error()})
return
}
c.Status(204)
}
...@@ -59,7 +59,7 @@ func OAuthLogin(ctx *middleware.Context) { ...@@ -59,7 +59,7 @@ func OAuthLogin(ctx *middleware.Context) {
Company: userInfo.Company, Company: userInfo.Company,
} }
if err = models.CreateAccount(account); err != nil { if err = models.SaveAccount(account); err != nil {
ctx.Handle(500, "Failed to create account", err) ctx.Handle(500, "Failed to create account", err)
return return
} }
......
...@@ -27,7 +27,7 @@ func CreateAccount(c *middleware.Context) { ...@@ -27,7 +27,7 @@ func CreateAccount(c *middleware.Context) {
Password: registerModel.Password, Password: registerModel.Password,
} }
err := models.CreateAccount(&account) err := models.SaveAccount(&account)
if err != nil { if err != nil {
log.Error(2, "Failed to create user account, email: %v, error: %v", registerModel.Email, err) log.Error(2, "Failed to create user account, email: %v, error: %v", registerModel.Email, err)
c.JSON(500, utils.DynMap{"status": "failed to create account"}) c.JSON(500, utils.DynMap{"status": "failed to create account"})
......
...@@ -6,8 +6,7 @@ import ( ...@@ -6,8 +6,7 @@ import (
) )
var ( var (
CreateAccount func(acccount *Account) error SaveAccount func(account *Account) error
UpdateAccount func(acccount *Account) error
GetAccountByLogin func(emailOrName string) (*Account, error) GetAccountByLogin func(emailOrName string) (*Account, error)
GetAccount func(accountId int64) (*Account, error) GetAccount func(accountId int64) (*Account, error)
GetOtherAccountsFor func(accountId int64) ([]*OtherAccount, error) GetOtherAccountsFor func(accountId int64) ([]*OtherAccount, error)
......
...@@ -29,7 +29,7 @@ var ( ...@@ -29,7 +29,7 @@ var (
func Init() { func Init() {
tables = append(tables, new(models.Account), new(models.Dashboard), new(models.Collaborator)) tables = append(tables, new(models.Account), new(models.Dashboard), new(models.Collaborator))
models.CreateAccount = CreateAccount models.SaveAccount = SaveAccount
models.GetAccount = GetAccount models.GetAccount = GetAccount
models.GetAccountByLogin = GetAccountByLogin models.GetAccountByLogin = GetAccountByLogin
models.GetOtherAccountsFor = GetOtherAccountsFor models.GetOtherAccountsFor = GetOtherAccountsFor
......
package sqlstore package sqlstore
import ( import "github.com/torkelo/grafana-pro/pkg/models"
"github.com/torkelo/grafana-pro/pkg/models"
)
func CreateAccount(account *models.Account) error { func SaveAccount(account *models.Account) error {
var err error var err error
sess := x.NewSession() sess := x.NewSession()
...@@ -14,7 +12,13 @@ func CreateAccount(account *models.Account) error { ...@@ -14,7 +12,13 @@ func CreateAccount(account *models.Account) error {
return err return err
} }
if _, err = sess.Insert(account); err != nil { if account.Id == 0 {
_, err = sess.Insert(account)
} else {
_, err = sess.Id(account.Id).Update(account)
}
if err != nil {
sess.Rollback() sess.Rollback()
return err return err
} else if err = sess.Commit(); err != nil { } else if err = sess.Commit(); err != nil {
......
...@@ -15,7 +15,7 @@ func SaveDashboard(dash *models.Dashboard) error { ...@@ -15,7 +15,7 @@ func SaveDashboard(dash *models.Dashboard) error {
if dash.Id == 0 { if dash.Id == 0 {
_, err = sess.Insert(dash) _, err = sess.Insert(dash)
} else { } else {
_, err = sess.Update(dash) _, err = sess.Id(dash.Id).Update(dash)
} }
if err != nil { if err != nil {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment