Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
N
nexpie-grafana-theme
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Registry
Registry
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Kornkitt Poolsup
nexpie-grafana-theme
Commits
736db86d
Commit
736db86d
authored
Jan 16, 2019
by
Peter Holmberg
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
removing Label and going with FormLabel
parent
01251927
Hide whitespace changes
Inline
Side-by-side
Showing
9 changed files
with
42 additions
and
49 deletions
+42
-49
packages/grafana-ui/src/components/FormField/FormField.tsx
+2
-2
packages/grafana-ui/src/components/FormLabel/FormLabel.tsx
+23
-4
packages/grafana-ui/src/components/Label/Label.tsx
+0
-25
packages/grafana-ui/src/components/ValueMappingsEditor/MappingRow.tsx
+4
-4
packages/grafana-ui/src/components/index.ts
+0
-1
public/app/core/components/SharedPreferences/SharedPreferences.tsx
+3
-3
public/app/features/datasources/settings/BasicSettings.tsx
+3
-3
public/app/features/teams/TeamSettings.tsx
+4
-4
public/app/plugins/panel/gauge/ValueOptions.tsx
+3
-3
No files found.
packages/grafana-ui/src/components/FormField/FormField.tsx
View file @
736db86d
import
React
,
{
InputHTMLAttributes
,
FunctionComponent
}
from
'react'
;
import
React
,
{
InputHTMLAttributes
,
FunctionComponent
}
from
'react'
;
import
{
Label
}
from
'..'
;
import
{
Form
Label
}
from
'..'
;
export
interface
Props
extends
InputHTMLAttributes
<
HTMLInputElement
>
{
export
interface
Props
extends
InputHTMLAttributes
<
HTMLInputElement
>
{
label
:
string
;
label
:
string
;
...
@@ -15,7 +15,7 @@ const defaultProps = {
...
@@ -15,7 +15,7 @@ const defaultProps = {
const
FormField
:
FunctionComponent
<
Props
>
=
({
label
,
labelWidth
,
inputWidth
,
...
inputProps
})
=>
{
const
FormField
:
FunctionComponent
<
Props
>
=
({
label
,
labelWidth
,
inputWidth
,
...
inputProps
})
=>
{
return
(
return
(
<
div
className=
"form-field"
>
<
div
className=
"form-field"
>
<
Label
width=
{
labelWidth
}
>
{
label
}
</
Label
>
<
FormLabel
width=
{
labelWidth
}
>
{
label
}
</
Form
Label
>
<
input
type=
"text"
className=
{
`gf-form-input width-${inputWidth}`
}
{
...
inputProps
}
/>
<
input
type=
"text"
className=
{
`gf-form-input width-${inputWidth}`
}
{
...
inputProps
}
/>
</
div
>
</
div
>
);
);
...
...
packages/grafana-ui/src/components/FormLabel/FormLabel.tsx
View file @
736db86d
import
React
,
{
SFC
,
ReactNode
}
from
'react'
;
import
React
,
{
FunctionComponent
,
ReactNode
}
from
'react'
;
import
classNames
from
'classnames'
;
import
classNames
from
'classnames'
;
import
{
Tooltip
}
from
'..'
;
interface
Props
{
interface
Props
{
children
:
ReactNode
;
children
:
ReactNode
;
htmlFor
?:
string
;
className
?:
string
;
className
?:
string
;
htmlFor
?:
string
;
isFocused
?:
boolean
;
isFocused
?:
boolean
;
isInvalid
?:
boolean
;
isInvalid
?:
boolean
;
tooltip
?:
string
;
width
?:
number
;
}
}
export
const
FormLabel
:
SFC
<
Props
>
=
({
children
,
isFocused
,
isInvalid
,
className
,
htmlFor
,
...
rest
})
=>
{
export
const
FormLabel
:
FunctionComponent
<
Props
>
=
({
const
classes
=
classNames
(
'gf-form-label'
,
className
,
{
children
,
isFocused
,
isInvalid
,
className
,
htmlFor
,
tooltip
,
width
,
...
rest
})
=>
{
const
classes
=
classNames
(
`gf-form-label width-
${
width
?
width
:
'10'
}
`
,
className
,
{
'gf-form-label--is-focused'
:
isFocused
,
'gf-form-label--is-focused'
:
isFocused
,
'gf-form-label--is-invalid'
:
isInvalid
,
'gf-form-label--is-invalid'
:
isInvalid
,
});
});
...
@@ -18,6 +30,13 @@ export const FormLabel: SFC<Props> = ({ children, isFocused, isInvalid, classNam
...
@@ -18,6 +30,13 @@ export const FormLabel: SFC<Props> = ({ children, isFocused, isInvalid, classNam
return
(
return
(
<
label
className=
{
classes
}
{
...
rest
}
htmlFor=
{
htmlFor
}
>
<
label
className=
{
classes
}
{
...
rest
}
htmlFor=
{
htmlFor
}
>
{
children
}
{
children
}
{
tooltip
&&
(
<
Tooltip
placement=
"auto"
content=
{
tooltip
}
>
<
div
className=
"gf-form-help-icon--right-normal"
>
<
i
className=
"gicon gicon-question gicon--has-hover"
/>
</
div
>
</
Tooltip
>
)
}
</
label
>
</
label
>
);
);
};
};
packages/grafana-ui/src/components/Label/Label.tsx
deleted
100644 → 0
View file @
01251927
import
React
,
{
SFC
,
ReactNode
}
from
'react'
;
import
{
Tooltip
}
from
'../Tooltip/Tooltip'
;
interface
Props
{
tooltip
?:
string
;
for
?:
string
;
children
:
ReactNode
;
width
?:
number
;
className
?:
string
;
}
export
const
Label
:
SFC
<
Props
>
=
props
=>
{
return
(
<
span
className=
{
`gf-form-label width-${props.width ? props.width : '10'}`
}
>
<
span
>
{
props
.
children
}
</
span
>
{
props
.
tooltip
&&
(
<
Tooltip
placement=
"auto"
content=
{
props
.
tooltip
}
>
<
div
className=
"gf-form-help-icon--right-normal"
>
<
i
className=
"gicon gicon-question gicon--has-hover"
/>
</
div
>
</
Tooltip
>
)
}
</
span
>
);
};
packages/grafana-ui/src/components/ValueMappingsEditor/MappingRow.tsx
View file @
736db86d
import
React
,
{
ChangeEvent
,
PureComponent
}
from
'react'
;
import
React
,
{
ChangeEvent
,
PureComponent
}
from
'react'
;
import
{
MappingType
,
ValueMapping
}
from
'../../types'
;
import
{
MappingType
,
ValueMapping
}
from
'../../types'
;
import
{
FormField
,
Label
,
Select
}
from
'..'
;
import
{
FormField
,
Form
Label
,
Select
}
from
'..'
;
export
interface
Props
{
export
interface
Props
{
valueMapping
:
ValueMapping
;
valueMapping
:
ValueMapping
;
...
@@ -78,7 +78,7 @@ export default class MappingRow extends PureComponent<Props, State> {
...
@@ -78,7 +78,7 @@ export default class MappingRow extends PureComponent<Props, State> {
value=
{
to
}
value=
{
to
}
/>
/>
<
div
className=
"gf-form gf-form--grow"
>
<
div
className=
"gf-form gf-form--grow"
>
<
Label
width=
{
4
}
>
Text
</
Label
>
<
FormLabel
width=
{
4
}
>
Text
</
Form
Label
>
<
input
<
input
className=
"gf-form-input"
className=
"gf-form-input"
onBlur=
{
this
.
updateMapping
}
onBlur=
{
this
.
updateMapping
}
...
@@ -101,7 +101,7 @@ export default class MappingRow extends PureComponent<Props, State> {
...
@@ -101,7 +101,7 @@ export default class MappingRow extends PureComponent<Props, State> {
inputWidth=
{
8
}
inputWidth=
{
8
}
/>
/>
<
div
className=
"gf-form gf-form--grow"
>
<
div
className=
"gf-form gf-form--grow"
>
<
Label
width=
{
4
}
>
Text
</
Label
>
<
FormLabel
width=
{
4
}
>
Text
</
Form
Label
>
<
input
<
input
className=
"gf-form-input"
className=
"gf-form-input"
onBlur=
{
this
.
updateMapping
}
onBlur=
{
this
.
updateMapping
}
...
@@ -119,7 +119,7 @@ export default class MappingRow extends PureComponent<Props, State> {
...
@@ -119,7 +119,7 @@ export default class MappingRow extends PureComponent<Props, State> {
return
(
return
(
<
div
className=
"gf-form-inline"
>
<
div
className=
"gf-form-inline"
>
<
div
className=
"gf-form"
>
<
div
className=
"gf-form"
>
<
Label
width=
{
5
}
>
Type
</
Label
>
<
FormLabel
width=
{
5
}
>
Type
</
Form
Label
>
<
Select
<
Select
placeholder=
"Choose type"
placeholder=
"Choose type"
isSearchable=
{
false
}
isSearchable=
{
false
}
...
...
packages/grafana-ui/src/components/index.ts
View file @
736db86d
...
@@ -12,7 +12,6 @@ export { default as resetSelectStyles } from './Select/resetSelectStyles';
...
@@ -12,7 +12,6 @@ export { default as resetSelectStyles } from './Select/resetSelectStyles';
// Forms
// Forms
export
{
FormLabel
}
from
'./FormLabel/FormLabel'
;
export
{
FormLabel
}
from
'./FormLabel/FormLabel'
;
export
{
FormField
}
from
'./FormField/FormField'
;
export
{
FormField
}
from
'./FormField/FormField'
;
export
{
Label
}
from
'./Label/Label'
;
export
{
LoadingPlaceholder
}
from
'./LoadingPlaceholder/LoadingPlaceholder'
;
export
{
LoadingPlaceholder
}
from
'./LoadingPlaceholder/LoadingPlaceholder'
;
export
{
ColorPicker
}
from
'./ColorPicker/ColorPicker'
;
export
{
ColorPicker
}
from
'./ColorPicker/ColorPicker'
;
...
...
public/app/core/components/SharedPreferences/SharedPreferences.tsx
View file @
736db86d
import
React
,
{
PureComponent
}
from
'react'
;
import
React
,
{
PureComponent
}
from
'react'
;
import
{
Label
,
Select
}
from
'@grafana/ui'
;
import
{
Form
Label
,
Select
}
from
'@grafana/ui'
;
import
{
getBackendSrv
,
BackendSrv
}
from
'app/core/services/backend_srv'
;
import
{
getBackendSrv
,
BackendSrv
}
from
'app/core/services/backend_srv'
;
import
{
DashboardSearchHit
}
from
'app/types'
;
import
{
DashboardSearchHit
}
from
'app/types'
;
...
@@ -99,12 +99,12 @@ export class SharedPreferences extends PureComponent<Props, State> {
...
@@ -99,12 +99,12 @@ export class SharedPreferences extends PureComponent<Props, State> {
/>
/>
</
div
>
</
div
>
<
div
className=
"gf-form"
>
<
div
className=
"gf-form"
>
<
Label
<
Form
Label
width=
{
11
}
width=
{
11
}
tooltip=
"Not finding dashboard you want? Star it first, then it should appear in this select box."
tooltip=
"Not finding dashboard you want? Star it first, then it should appear in this select box."
>
>
Home Dashboard
Home Dashboard
</
Label
>
</
Form
Label
>
<
Select
<
Select
value=
{
dashboards
.
find
(
dashboard
=>
dashboard
.
id
===
homeDashboardId
)
}
value=
{
dashboards
.
find
(
dashboard
=>
dashboard
.
id
===
homeDashboardId
)
}
getOptionValue=
{
i
=>
i
.
id
}
getOptionValue=
{
i
=>
i
.
id
}
...
...
public/app/features/datasources/settings/BasicSettings.tsx
View file @
736db86d
import
React
,
{
SFC
}
from
'react'
;
import
React
,
{
SFC
}
from
'react'
;
import
{
Label
}
from
'@grafana/ui'
;
import
{
Form
Label
}
from
'@grafana/ui'
;
import
{
Switch
}
from
'../../../core/components/Switch/Switch'
;
import
{
Switch
}
from
'../../../core/components/Switch/Switch'
;
export
interface
Props
{
export
interface
Props
{
...
@@ -14,14 +14,14 @@ const BasicSettings: SFC<Props> = ({ dataSourceName, isDefault, onDefaultChange,
...
@@ -14,14 +14,14 @@ const BasicSettings: SFC<Props> = ({ dataSourceName, isDefault, onDefaultChange,
<
div
className=
"gf-form-group"
>
<
div
className=
"gf-form-group"
>
<
div
className=
"gf-form-inline"
>
<
div
className=
"gf-form-inline"
>
<
div
className=
"gf-form max-width-30"
style=
{
{
marginRight
:
'3px'
}
}
>
<
div
className=
"gf-form max-width-30"
style=
{
{
marginRight
:
'3px'
}
}
>
<
Label
<
Form
Label
tooltip=
{
tooltip=
{
'The name is used when you select the data source in panels. The Default data source is '
+
'The name is used when you select the data source in panels. The Default data source is '
+
'preselected in new panels.'
'preselected in new panels.'
}
}
>
>
Name
Name
</
Label
>
</
Form
Label
>
<
input
<
input
className=
"gf-form-input max-width-23"
className=
"gf-form-input max-width-23"
type=
"text"
type=
"text"
...
...
public/app/features/teams/TeamSettings.tsx
View file @
736db86d
import
React
from
'react'
;
import
React
from
'react'
;
import
{
connect
}
from
'react-redux'
;
import
{
connect
}
from
'react-redux'
;
import
{
Label
}
from
'@grafana/ui'
;
import
{
Form
Label
}
from
'@grafana/ui'
;
import
{
SharedPreferences
}
from
'app/core/components/SharedPreferences/SharedPreferences'
;
import
{
SharedPreferences
}
from
'app/core/components/SharedPreferences/SharedPreferences'
;
import
{
updateTeam
}
from
'./state/actions'
;
import
{
updateTeam
}
from
'./state/actions'
;
...
@@ -51,7 +51,7 @@ export class TeamSettings extends React.Component<Props, State> {
...
@@ -51,7 +51,7 @@ export class TeamSettings extends React.Component<Props, State> {
<
h3
className=
"page-sub-heading"
>
Team Settings
</
h3
>
<
h3
className=
"page-sub-heading"
>
Team Settings
</
h3
>
<
form
name=
"teamDetailsForm"
className=
"gf-form-group"
onSubmit=
{
this
.
onUpdate
}
>
<
form
name=
"teamDetailsForm"
className=
"gf-form-group"
onSubmit=
{
this
.
onUpdate
}
>
<
div
className=
"gf-form max-width-30"
>
<
div
className=
"gf-form max-width-30"
>
<
Label
>
Name
</
Label
>
<
FormLabel
>
Name
</
Form
Label
>
<
input
<
input
type=
"text"
type=
"text"
required
required
...
@@ -62,9 +62,9 @@ export class TeamSettings extends React.Component<Props, State> {
...
@@ -62,9 +62,9 @@ export class TeamSettings extends React.Component<Props, State> {
</
div
>
</
div
>
<
div
className=
"gf-form max-width-30"
>
<
div
className=
"gf-form max-width-30"
>
<
Label
tooltip=
"This is optional and is primarily used to set the team profile avatar (via gravatar service)"
>
<
Form
Label
tooltip=
"This is optional and is primarily used to set the team profile avatar (via gravatar service)"
>
Email
Email
</
Label
>
</
Form
Label
>
<
input
<
input
type=
"email"
type=
"email"
className=
"gf-form-input max-width-22"
className=
"gf-form-input max-width-22"
...
...
public/app/plugins/panel/gauge/ValueOptions.tsx
View file @
736db86d
import
React
,
{
PureComponent
}
from
'react'
;
import
React
,
{
PureComponent
}
from
'react'
;
import
{
FormField
,
Label
,
PanelOptionsProps
,
PanelOptionsGroup
,
Select
}
from
'@grafana/ui'
;
import
{
FormField
,
Form
Label
,
PanelOptionsProps
,
PanelOptionsGroup
,
Select
}
from
'@grafana/ui'
;
import
UnitPicker
from
'app/core/components/Select/UnitPicker'
;
import
UnitPicker
from
'app/core/components/Select/UnitPicker'
;
import
{
GaugeOptions
}
from
'./types'
;
import
{
GaugeOptions
}
from
'./types'
;
...
@@ -40,7 +40,7 @@ export default class ValueOptions extends PureComponent<PanelOptionsProps<GaugeO
...
@@ -40,7 +40,7 @@ export default class ValueOptions extends PureComponent<PanelOptionsProps<GaugeO
return
(
return
(
<
PanelOptionsGroup
title=
"Value"
>
<
PanelOptionsGroup
title=
"Value"
>
<
div
className=
"gf-form"
>
<
div
className=
"gf-form"
>
<
Label
width=
{
labelWidth
}
>
Stat
</
Label
>
<
FormLabel
width=
{
labelWidth
}
>
Stat
</
Form
Label
>
<
Select
<
Select
width=
{
12
}
width=
{
12
}
options=
{
statOptions
}
options=
{
statOptions
}
...
@@ -49,7 +49,7 @@ export default class ValueOptions extends PureComponent<PanelOptionsProps<GaugeO
...
@@ -49,7 +49,7 @@ export default class ValueOptions extends PureComponent<PanelOptionsProps<GaugeO
/>
/>
</
div
>
</
div
>
<
div
className=
"gf-form"
>
<
div
className=
"gf-form"
>
<
Label
width=
{
labelWidth
}
>
Unit
</
Label
>
<
FormLabel
width=
{
labelWidth
}
>
Unit
</
Form
Label
>
<
UnitPicker
defaultValue=
{
unit
}
onChange=
{
this
.
onUnitChange
}
/>
<
UnitPicker
defaultValue=
{
unit
}
onChange=
{
this
.
onUnitChange
}
/>
</
div
>
</
div
>
<
FormField
<
FormField
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment