DataLinks: Do not add empty links (#24088)

* Do not add empty links

* Review

packages/grafana-ui/src/components/DataLinks/DataLinksInlineEditor/DataLinkEditorModalContent.tsx

@@ -9,16 +9,16 @@ interface DataLinkEditorModalContentProps {
   index: number;
   index: number;
   data: DataFrame[];
   data: DataFrame[];
   suggestions: VariableSuggestion[];
   suggestions: VariableSuggestion[];
-  onChange: (index: number, ink: DataLink) => void;
-  onClose: () => void;
+  onSave: (index: number, ink: DataLink) => void;
+  onCancel: (index: number) => void;
 }
 }
 
 
 export const DataLinkEditorModalContent: FC<DataLinkEditorModalContentProps> = ({
 export const DataLinkEditorModalContent: FC<DataLinkEditorModalContentProps> = ({
   link,
   link,
   index,
   index,
   suggestions,
   suggestions,
-  onChange,
-  onClose,
+  onSave,
+  onCancel,
 }) => {
 }) => {
   const [dirtyLink, setDirtyLink] = useState(link);
   const [dirtyLink, setDirtyLink] = useState(link);
   return (
   return (
@@ -35,13 +35,12 @@ export const DataLinkEditorModalContent: FC<DataLinkEditorModalContentProps> = (
       <HorizontalGroup>
       <HorizontalGroup>
         <Button
         <Button
           onClick={() => {
           onClick={() => {
-            onChange(index, dirtyLink);
-            onClose();
+            onSave(index, dirtyLink);
           }}
           }}
         >
         >
           Save
           Save
         </Button>
         </Button>
-        <Button variant="secondary" onClick={() => onClose()}>
+        <Button variant="secondary" onClick={() => onCancel(index)}>
           Cancel
           Cancel
         </Button>
         </Button>
       </HorizontalGroup>
       </HorizontalGroup>

packages/grafana-ui/src/components/DataLinks/DataLinksInlineEditor/DataLinksInlineEditor.tsx

@@ -18,26 +18,40 @@ interface DataLinksInlineEditorProps {
 export const DataLinksInlineEditor: React.FC<DataLinksInlineEditorProps> = ({ links, onChange, suggestions, data }) => {
 export const DataLinksInlineEditor: React.FC<DataLinksInlineEditorProps> = ({ links, onChange, suggestions, data }) => {
   const theme = useTheme();
   const theme = useTheme();
   const [editIndex, setEditIndex] = useState<number | null>(null);
   const [editIndex, setEditIndex] = useState<number | null>(null);
+  const [isNew, setIsNew] = useState(false);
+
   const styles = getDataLinksInlineEditorStyles(theme);
   const styles = getDataLinksInlineEditorStyles(theme);
   const linksSafe: DataLink[] = links ?? [];
   const linksSafe: DataLink[] = links ?? [];
-  const isEditing = editIndex !== null && linksSafe[editIndex] !== undefined;
+  const isEditing = editIndex !== null;
 
 
   const onDataLinkChange = (index: number, link: DataLink) => {
   const onDataLinkChange = (index: number, link: DataLink) => {
+    if (isNew) {
+      if (link.title.trim() === '' && link.url.trim() === '') {
+        setIsNew(false);
+        setEditIndex(null);
+        return;
+      } else {
+        setEditIndex(null);
+        setIsNew(false);
+      }
+    }
     const update = cloneDeep(linksSafe);
     const update = cloneDeep(linksSafe);
     update[index] = link;
     update[index] = link;
     onChange(update);
     onChange(update);
+    setEditIndex(null);
   };
   };
 
 
   const onDataLinkAdd = () => {
   const onDataLinkAdd = () => {
     let update = cloneDeep(linksSafe);
     let update = cloneDeep(linksSafe);
+    setEditIndex(update.length);
+    setIsNew(true);
+  };
 
 
-    update.push({
-      title: '',
-      url: '',
-    });
-
-    setEditIndex(update.length - 1);
-    onChange(update);
+  const onDataLinkCancel = (index: number) => {
+    if (isNew) {
+      setIsNew(false);
+    }
+    setEditIndex(null);
   };
   };
 
 
   const onDataLinkRemove = (index: number) => {
   const onDataLinkRemove = (index: number) => {
@@ -72,15 +86,15 @@ export const DataLinksInlineEditor: React.FC<DataLinksInlineEditorProps> = ({ li
           title="Edit link"
           title="Edit link"
           isOpen={true}
           isOpen={true}
           onDismiss={() => {
           onDismiss={() => {
-            setEditIndex(null);
+            onDataLinkCancel(editIndex);
           }}
           }}
         >
         >
           <DataLinkEditorModalContent
           <DataLinkEditorModalContent
             index={editIndex}
             index={editIndex}
-            link={linksSafe[editIndex]}
+            link={isNew ? { title: '', url: '' } : linksSafe[editIndex]}
             data={data}
             data={data}
-            onChange={onDataLinkChange}
-            onClose={() => setEditIndex(null)}
+            onSave={onDataLinkChange}
+            onCancel={onDataLinkCancel}
             suggestions={suggestions}
             suggestions={suggestions}
           />
           />
         </Modal>
         </Modal>