renderer: avoid calling Handle twice

8a5fe5b0 · bergquist · 7a8a52a1 · 8a5fe5b0
Commit 8a5fe5b0 authored Dec 28, 2017 by bergquist
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 4 deletions

pkg/api/render.go
+5 -4

No files found.
--- a/pkg/api/render.go
+++ b/pkg/api/render.go
@@ -31,11 +31,12 @@ func RenderToPng(c *middleware.Context) {

 	pngPath, err := renderer.RenderToPng(renderOpts)

-	if err != nil {
-		if err == renderer.ErrTimeout {
-			c.Handle(500, err.Error(), err)
-		}
+	if err != nil && err == renderer.ErrTimeout {
+		c.Handle(500, err.Error(), err)
+		return
+	}

+	if err != nil {
 		c.Handle(500, "Rendering failed.", err)
 		return
 	}