Handle unpublish by deprecating package (#23310)

* Handle unpublish by deprecating package

* Fixed tabs.

* fixed array iterate

* Fixed quoting problems

* various shellcheck fixes

scripts/circle-release-next-packages.sh

 #!/usr/bin/env bash
 #!/usr/bin/env bash
 
 
+PACKAGES=(ui toolkit data runtime e2e)
+
 # shellcheck source=./scripts/helpers/exit-if-fail.sh
 # shellcheck source=./scripts/helpers/exit-if-fail.sh
 source "$(dirname "$0")/helpers/exit-if-fail.sh"
 source "$(dirname "$0")/helpers/exit-if-fail.sh"
 
 
@@ -16,15 +18,24 @@ function prapare_version_commit () {
 
 
 function unpublish_previous_canary () {
 function unpublish_previous_canary () {
   echo $'\nUnpublishing previous canary packages'
   echo $'\nUnpublishing previous canary packages'
-  for PACKAGE in ui toolkit data runtime e2e
+  for PACKAGE in "${PACKAGES[@]}"
   do
   do
     # dist-tag next to be changed to canary when https://github.com/grafana/grafana/pull/18195 is merged
     # dist-tag next to be changed to canary when https://github.com/grafana/grafana/pull/18195 is merged
-    CURRENT_CANARY=$(npm view @grafana/${PACKAGE} dist-tags.canary)
+    CURRENT_CANARY=$(npm view @grafana/"${PACKAGE}" dist-tags.canary)
     if [ -z "${CURRENT_CANARY}" ]; then
     if [ -z "${CURRENT_CANARY}" ]; then
         echo "@grafana/${PACKAGE} - Nothing to unpublish"
         echo "@grafana/${PACKAGE} - Nothing to unpublish"
     else
     else
       echo "Unpublish @grafana/${PACKAGE}@${CURRENT_CANARY}"
       echo "Unpublish @grafana/${PACKAGE}@${CURRENT_CANARY}"
-      npm unpublish "@grafana/${PACKAGE}@${CURRENT_CANARY}"
+      npm unpublish "@grafana/${PACKAGE}@${CURRENT_CANARY}" || (
+        # We want to deprecate here, rather than fail and return an non-0 exit code
+        npm deprecate \
+          "@grafana/${PACKAGE}@${CURRENT_CANARY}" \
+          "Unpublish failed with [$?]. Deprecating \"@grafana/${PACKAGE}@${CURRENT_CANARY}\"" || (
+            # Echoing a log message will ultimately change the error code, so save the error
+            # code and return it after printing an error log.
+            echo "Could not deprecate \"@grafana/${PACKAGE}@${CURRENT_CANARY}\". Received exit-code [$?]"
+        )
+      )
     fi
     fi
   done
   done
 }
 }
@@ -52,10 +63,10 @@ else
 
 
   echo $'\nBuilding packages'
   echo $'\nBuilding packages'
 
 
-  for PACKAGE in ui data toolkit runtime e2e
+  for PACKAGE in "${PACKAGES[@]}"
   do
   do
     start=$(date +%s%N)
     start=$(date +%s%N)
-    yarn workspace @grafana/$PACKAGE run build
+    yarn workspace @grafana/"${PACKAGE}" run build
     runtime=$((($(date +%s%N) - start)/1000000))
     runtime=$((($(date +%s%N) - start)/1000000))
     if [ "${CIRCLE_BRANCH}" == "master" ]; then
     if [ "${CIRCLE_BRANCH}" == "master" ]; then
     exit_if_fail ./scripts/ci-metrics-publisher.sh "grafana.ci-buildtimes.$CIRCLE_JOB.$PACKAGE=$runtime"
     exit_if_fail ./scripts/ci-metrics-publisher.sh "grafana.ci-buildtimes.$CIRCLE_JOB.$PACKAGE=$runtime"