feat(instrumentation): finial polish

pkg/api/dataproxy.go

@@ -17,8 +17,6 @@ import (
 	"github.com/grafana/grafana/pkg/util"
 	"github.com/grafana/grafana/pkg/util"
 )
 )
 
 
-var i int = 0
-
 var dataProxyTransport = &http.Transport{
 var dataProxyTransport = &http.Transport{
 	TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
 	TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
 	Proxy:           http.ProxyFromEnvironment,
 	Proxy:           http.ProxyFromEnvironment,

pkg/metrics/metrics.go

 package metrics
 package metrics
 
 
-var MetricStats = NewRegistry()
-var UseNilMetrics bool = true
+var MetricStats Registry
+var UseNilMetrics bool
+
+func init() {
+	// init with nil metrics
+	initMetricVars(&MetricSettings{})
+}
 
 
 var (
 var (
 	M_Instance_Start                  Counter
 	M_Instance_Start                  Counter
@@ -31,6 +36,7 @@ var (
 
 
 func initMetricVars(settings *MetricSettings) {
 func initMetricVars(settings *MetricSettings) {
 	UseNilMetrics = settings.Enabled == false
 	UseNilMetrics = settings.Enabled == false
+	MetricStats = NewRegistry()
 
 
 	M_Instance_Start = RegCounter("instance_start")
 	M_Instance_Start = RegCounter("instance_start")