always quote template variables for mysql when multi-value is allowed (#9712)

* always quote template variables for mysql when multi-value is allowed

* handle include all option similar to multi value

* declare type

* adjust tests to quoting change

* dont specify type but let it be inferred

* fix test for variable with includeAll

public/app/plugins/datasource/mysql/datasource.ts

@@ -15,9 +15,13 @@ export class MysqlDatasource {
     this.responseParser = new ResponseParser(this.$q);
     this.responseParser = new ResponseParser(this.$q);
   }
   }
 
 
-  interpolateVariable(value) {
+  interpolateVariable(value, variable) {
     if (typeof value === 'string') {
     if (typeof value === 'string') {
-      return value;
+      if (variable.multi || variable.includeAll) {
+        return '\'' + value + '\'';
+      } else {
+        return value;
+      }
     }
     }
 
 
     if (typeof value === 'number') {
     if (typeof value === 'number') {

public/app/plugins/datasource/mysql/specs/datasource_specs.ts

@@ -2,6 +2,7 @@ import {describe, beforeEach, it, expect, angularMocks} from 'test/lib/common';
 import moment from 'moment';
 import moment from 'moment';
 import helpers from 'test/specs/helpers';
 import helpers from 'test/specs/helpers';
 import {MysqlDatasource} from '../datasource';
 import {MysqlDatasource} from '../datasource';
+import {CustomVariable} from 'app/features/templating/custom_variable';
 
 
 describe('MySQLDatasource', function() {
 describe('MySQLDatasource', function() {
   var ctx = new helpers.ServiceTestContext();
   var ctx = new helpers.ServiceTestContext();
@@ -195,22 +196,41 @@ describe('MySQLDatasource', function() {
   });
   });
 
 
   describe('When interpolating variables', () => {
   describe('When interpolating variables', () => {
+    beforeEach(function() {
+      ctx.variable = new CustomVariable({},{});
+    });
+
     describe('and value is a string', () => {
     describe('and value is a string', () => {
       it('should return an unquoted value', () => {
       it('should return an unquoted value', () => {
-        expect(ctx.ds.interpolateVariable('abc')).to.eql('abc');
+        expect(ctx.ds.interpolateVariable('abc', ctx.variable)).to.eql('abc');
       });
       });
     });
     });
 
 
     describe('and value is a number', () => {
     describe('and value is a number', () => {
       it('should return an unquoted value', () => {
       it('should return an unquoted value', () => {
-        expect(ctx.ds.interpolateVariable(1000)).to.eql(1000);
+        expect(ctx.ds.interpolateVariable(1000, ctx.variable)).to.eql(1000);
       });
       });
     });
     });
 
 
     describe('and value is an array of strings', () => {
     describe('and value is an array of strings', () => {
       it('should return comma separated quoted values', () => {
       it('should return comma separated quoted values', () => {
-        expect(ctx.ds.interpolateVariable(['a', 'b', 'c'])).to.eql('\'a\',\'b\',\'c\'');
+        expect(ctx.ds.interpolateVariable(['a', 'b', 'c'], ctx.variable)).to.eql('\'a\',\'b\',\'c\'');
+      });
+    });
+
+    describe('and variable allows multi-value and value is a string', () => {
+      it('should return a quoted value', () => {
+        ctx.variable.multi = true;
+        expect(ctx.ds.interpolateVariable('abc', ctx.variable)).to.eql('\'abc\'');
       });
       });
     });
     });
+
+    describe('and variable allows all and value is a string', () => {
+      it('should return a quoted value', () => {
+        ctx.variable.includeAll = true;
+        expect(ctx.ds.interpolateVariable('abc', ctx.variable)).to.eql('\'abc\'');
+      });
+    });
+
   });
   });
 });
 });