Commit e351e6e2 by Mario Trangoni

pkg/tsdb/influxdb/influxdb.go: Fix surrounding loop is unconditionally terminated.

See,
$ gometalinter --vendor --deadline 6m --disable-all --enable=megacheck ./...
pkg/tsdb/influxdb/influxdb.go:106:3:warning: the surrounding loop is unconditionally terminated (SA4004) (megacheck)
parent 960651e5
...@@ -96,16 +96,15 @@ func (e *InfluxDBExecutor) Query(ctx context.Context, dsInfo *models.DataSource, ...@@ -96,16 +96,15 @@ func (e *InfluxDBExecutor) Query(ctx context.Context, dsInfo *models.DataSource,
} }
func (e *InfluxDBExecutor) getQuery(dsInfo *models.DataSource, queries []*tsdb.Query, context *tsdb.TsdbQuery) (*Query, error) { func (e *InfluxDBExecutor) getQuery(dsInfo *models.DataSource, queries []*tsdb.Query, context *tsdb.TsdbQuery) (*Query, error) {
for _, v := range queries { // The model supports multiple queries, but right now this is only used from
// alerting so we only needed to support batch executing 1 query at a time.
query, err := e.QueryParser.Parse(v.Model, dsInfo) if len(queries) > 0 {
query, err := e.QueryParser.Parse(queries[0].Model, dsInfo)
if err != nil { if err != nil {
return nil, err return nil, err
} }
return query, nil return query, nil
} }
return nil, fmt.Errorf("query request contains no queries") return nil, fmt.Errorf("query request contains no queries")
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment