Commit ee132c10 by corpglory-dev

Fix SemVersion.isGtOrEq

parent 43b5eba8
...@@ -20,12 +20,25 @@ export class SemVersion { ...@@ -20,12 +20,25 @@ export class SemVersion {
isGtOrEq(version: string): boolean { isGtOrEq(version: string): boolean {
const compared = new SemVersion(version); const compared = new SemVersion(version);
return !(this.major < compared.major || this.minor < compared.minor || this.patch < compared.patch);
for (let i = 0; i < this.comparable.length; ++i) {
if (this.comparable[i] > compared.comparable[i]) {
return true;
}
if (this.comparable[i] < compared.comparable[i]) {
return false;
}
}
return true;
} }
isValid(): boolean { isValid(): boolean {
return _.isNumber(this.major); return _.isNumber(this.major);
} }
get comparable() {
return [this.major, this.minor, this.patch];
}
} }
export function isVersionGtOrEq(a: string, b: string): boolean { export function isVersionGtOrEq(a: string, b: string): boolean {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment