1. 16 Apr, 2018 28 commits
    • Use fmt.Errorf() (gosimple) · 4d6386e9
      This fixes:
      pkg/cmd/grafana-cli/commands/install_command.go:36:11: should use fmt.Errorf(...) instead of errors.New(fmt.Sprintf(...)) (S1028)
      pkg/models/org_user.go:53:11: should use fmt.Errorf(...) instead of errors.New(fmt.Sprintf(...)) (S1028)
      pkg/services/notifications/mailer.go:138:16: should use fmt.Errorf(...) instead of errors.New(fmt.Sprintf(...)) (S1028)
      Karsten Weiss committed
    • Simplify make() (gosimple) · 4d87cb03
      This fixes:
      pkg/api/http_server.go:142:89: should use make(map[string]func(*http.Server, *tls.Conn, http.Handler)) instead (S1019)
      pkg/services/alerting/scheduler.go:18:30: should use make(map[int64]*Job) instead (S1019)
      pkg/services/alerting/scheduler.go:26:31: should use make(map[int64]*Job) instead (S1019)
      Karsten Weiss committed
    • Use raw strings to avoid double escapes (gosimple) · cb3b9f8b
      This fixes:
      pkg/services/alerting/rule.go:58:21: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007\)
      pkg/services/alerting/rule.go:59:21: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007)
      Karsten Weiss committed
    • Simplify if expression (gosimple) · da5654ad
      pkg/util/shortid_generator.go:20:2: should use 'return <expr>' instead of 'if <expr> { return <bool> }; return <bool>' (S1008)
      Karsten Weiss committed
    • Simplify comparison to bool constant (gosimple) · f61e69ce
      This fixes:
      build.go:553:6: should omit comparison to bool constant, can be simplified to !strings.Contains(path, ".sha256") (S1002)
      pkg/cmd/grafana-cli/commands/ls_command.go:27:5: should omit comparison to bool constant, can be simplified to !pluginDirInfo.IsDir() (S1002)
      pkg/components/dynmap/dynmap_test.go:24:5: should omit comparison to bool constant, can be simplified to !value (S1002)
      pkg/components/dynmap/dynmap_test.go:122:14: should omit comparison to bool constant, can be simplified to b (S1002)
      pkg/components/dynmap/dynmap_test.go:125:14: should omit comparison to bool constant, can be simplified to !b (S1002)
      pkg/components/dynmap/dynmap_test.go:128:14: should omit comparison to bool constant, can be simplified to !b (S1002)
      pkg/models/org_user.go:51:5: should omit comparison to bool constant, can be simplified to !(*r).IsValid() (S1002)
      pkg/plugins/datasource/wrapper/datasource_plugin_wrapper_test.go:77:12: should omit comparison to bool constant, can be simplified to !haveBool (S1002)
      pkg/services/alerting/conditions/evaluator.go:23:9: should omit comparison to bool constant, can be simplified to !reducedValue.Valid (S1002)
      pkg/services/alerting/conditions/evaluator.go:48:5: should omit comparison to bool constant, can be simplified to !reducedValue.Valid (S1002)
      pkg/services/alerting/conditions/evaluator.go:91:5: should omit comparison to bool constant, can be simplified to !reducedValue.Valid (S1002)
      pkg/services/alerting/conditions/query.go:56:6: should omit comparison to bool constant, can be simplified to !reducedValue.Valid (S1002)
      pkg/services/alerting/extractor.go:107:20: should omit comparison to bool constant, can be simplified to !enabled.MustBool() (S1002)
      pkg/services/alerting/notifiers/telegram.go:222:41: should omit comparison to bool constant, can be simplified to this.UploadImage (S1002)
      pkg/services/sqlstore/apikey.go:58:12: should omit comparison to bool constant, can be simplified to !has (S1002)
      pkg/services/sqlstore/apikey.go:72:12: should omit comparison to bool constant, can be simplified to !has (S1002)
      pkg/services/sqlstore/dashboard.go:66:33: should omit comparison to bool constant, can be simplified to !cmd.Overwrite (S1002)
      pkg/services/sqlstore/dashboard.go:175:12: should omit comparison to bool constant, can be simplified to !has (S1002)
      pkg/services/sqlstore/dashboard.go:311:13: should omit comparison to bool constant, can be simplified to !has (S1002)
      pkg/services/sqlstore/dashboard.go:444:12: should omit comparison to bool constant, can be simplified to !exists (S1002)
      pkg/services/sqlstore/dashboard.go:472:12: should omit comparison to bool constant, can be simplified to !exists (S1002)
      pkg/services/sqlstore/dashboard.go:554:32: should omit comparison to bool constant, can be simplified to !cmd.Overwrite (S1002)
      pkg/services/sqlstore/dashboard_snapshot.go:83:12: should omit comparison to bool constant, can be simplified to !has (S1002)
      pkg/services/sqlstore/plugin_setting.go:39:12: should omit comparison to bool constant, can be simplified to !has (S1002)
      pkg/services/sqlstore/quota.go:34:12: should omit comparison to bool constant, can be simplified to !has (S1002)
      pkg/services/sqlstore/quota.go:111:6: should omit comparison to bool constant, can be simplified to !has (S1002)
      pkg/services/sqlstore/quota.go:136:12: should omit comparison to bool constant, can be simplified to !has (S1002)
      pkg/services/sqlstore/quota.go:213:6: should omit comparison to bool constant, can be simplified to !has (S1002)
      pkg/services/sqlstore/temp_user.go:129:12: should omit comparison to bool constant, can be simplified to !has (S1002)
      pkg/services/sqlstore/user.go:157:12: should omit comparison to bool constant, can be simplified to !has (S1002)
      pkg/services/sqlstore/user.go:182:5: should omit comparison to bool constant, can be simplified to !has (S1002)
      pkg/services/sqlstore/user.go:191:12: should omit comparison to bool constant, can be simplified to !has (S1002)
      pkg/services/sqlstore/user.go:212:12: should omit comparison to bool constant, can be simplified to !has (S1002)
      pkg/services/sqlstore/user.go:307:12: should omit comparison to bool constant, can be simplified to !has (S1002)
      pkg/social/generic_oauth.go:185:5: should omit comparison to bool constant, can be simplified to !s.extractToken(&data, token) (S1002)
      pkg/tsdb/mssql/mssql.go:148:39: should omit comparison to bool constant, can be simplified to ok (S1002)
      pkg/tsdb/mssql/mssql.go:212:6: should omit comparison to bool constant, can be simplified to !query.Model.Get("fillNull").MustBool(false) (S1002)
      pkg/tsdb/mssql/mssql.go:247:56: should omit comparison to bool constant, can be simplified to ok (S1002)
      pkg/tsdb/mssql/mssql.go:274:7: should omit comparison to bool constant, can be simplified to !exist (S1002)
      pkg/tsdb/mssql/mssql.go:282:8: should omit comparison to bool constant, can be simplified to !exist (S1002)
      pkg/tsdb/mysql/mysql.go:221:6: should omit comparison to bool constant, can be simplified to !query.Model.Get("fillNull").MustBool(false) (S1002)
      pkg/tsdb/mysql/mysql.go:256:56: should omit comparison to bool constant, can be simplified to ok (S1002)
      pkg/tsdb/mysql/mysql.go:283:7: should omit comparison to bool constant, can be simplified to !exist (S1002)
      pkg/tsdb/mysql/mysql.go:291:8: should omit comparison to bool constant, can be simplified to !exist (S1002)
      pkg/tsdb/postgres/postgres.go:134:39: should omit comparison to bool constant, can be simplified to ok (S1002)
      pkg/tsdb/postgres/postgres.go:201:6: should omit comparison to bool constant, can be simplified to !query.Model.Get("fillNull").MustBool(false) (S1002)
      pkg/tsdb/postgres/postgres.go:236:56: should omit comparison to bool constant, can be simplified to ok (S1002)
      pkg/tsdb/postgres/postgres.go:263:7: should omit comparison to bool constant, can be simplified to !exist (S1002)
      pkg/tsdb/postgres/postgres.go:271:8: should omit comparison to bool constant, can be simplified to !exist (S1002)
      Karsten Weiss committed
    • Simplify error returns (gosimple) · be2d6350
      This fixes:
      pkg/api/avatar/avatar.go:261:2: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
      pkg/log/file.go:102:2: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
      pkg/metrics/graphitebridge/graphite.go:298:2: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
      pkg/services/provisioning/provisioning.go:23:2: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
      pkg/services/sqlstore/alert_notification.go:27:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
      pkg/services/sqlstore/alert_notification.go:27:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
      pkg/services/sqlstore/annotation.go:105:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
      pkg/services/sqlstore/annotation.go:105:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
      pkg/services/sqlstore/dashboard.go:351:2: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
      pkg/services/sqlstore/dashboard.go:435:2: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
      pkg/services/sqlstore/dashboard_acl.go:38:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
      pkg/services/sqlstore/dashboard_acl.go:38:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
      pkg/services/sqlstore/stats.go:22:2: 'if err != nil { return err }; return err' can be simplified to 'return err' (S1013)
      pkg/services/sqlstore/team.go:213:2: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
      pkg/services/sqlstore/user.go:256:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
      pkg/services/sqlstore/user.go:256:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
      pkg/services/sqlstore/user.go:274:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
      pkg/services/sqlstore/user.go:274:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
      pkg/services/sqlstore/user.go:482:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
      pkg/services/sqlstore/user.go:482:3: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
      Karsten Weiss committed
    • Remove redundant break statements (gosimple) · c5a09a3d
      This fixes:
      pkg/components/dynmap/dynmap.go:588:3: redundant break statement (S1023)
      pkg/components/dynmap/dynmap.go:610:3: redundant break statement (S1023)
      pkg/components/dynmap/dynmap.go:641:3: redundant break statement (S1023)
      pkg/components/dynmap/dynmap.go:690:3: redundant break statement (S1023)
      pkg/components/dynmap/dynmap.go:712:3: redundant break statement (S1023)
      pkg/components/dynmap/dynmap.go:749:3: redundant break statement (S1023)
      pkg/components/dynmap/dynmap.go:785:3: redundant break statement (S1023)
      pkg/tsdb/cloudwatch/cloudwatch.go:74:3: redundant break statement (S1023)
      pkg/tsdb/cloudwatch/cloudwatch.go:77:3: redundant break statement (S1023)
      pkg/tsdb/cloudwatch/cloudwatch.go:82:3: redundant break statement (S1023)
      pkg/tsdb/cloudwatch/metric_find_query.go:178:3: redundant break statement (S1023)
      pkg/tsdb/cloudwatch/metric_find_query.go:181:3: redundant break statement (S1023)
      pkg/tsdb/cloudwatch/metric_find_query.go:184:3: redundant break statement (S1023)
      pkg/tsdb/cloudwatch/metric_find_query.go:187:3: redundant break statement (S1023)
      pkg/tsdb/cloudwatch/metric_find_query.go:190:3: redundant break statement (S1023)
      pkg/tsdb/cloudwatch/metric_find_query.go:193:3: redundant break statement (S1023)
      pkg/tsdb/cloudwatch/metric_find_query.go:196:3: redundant break statement (S1023)
      Karsten Weiss committed
    • fix merge conflict · 7d165068
      Daniel Lee committed
    • migrated dropdown-typeahead to ts (#11499) · 7ef61061
      * migrated dropdown-typeahead to ts
      
      * removed console.logs
      
      * added @ngInject
      Patrick O'Carroll committed
    • Merge pull request #11583 from grafana/11556-org-switch-order · 34455c05
      ordered user orgs alphabeticaly 
      Daniel Lee committed
    • Merge pull request #11595 from kichristensen/DeleteEmptyPlaylist · bb7a6a01
      Support deleting empty playlist
      Daniel Lee committed
    • Merge pull request #11605 from grafana/davkal/show-version-in-help · ed44face
      Show Grafana version and build in Help menu
      David committed
    • Show Grafana version and build in Help menu · 712212d6
      * establishes Help as the single place to look for the Grafana version
      * version is passed as menu sub-title to side menu
      * added rendering of sub-title, plus styles
      * sub-title was used by profile menu (its value is the login string),
      but was not shown; now showing this value on condition that login name
      is different from user name
      David Kaltschmidt committed
    • changlelog: notes about closing issues/pr's · 645658d7
      #11053, #11252, #10836, #11185, #11168, #11332, #11391, #11073, #9342, #11001, #11183, #11211, #11384, #11095, #10792, #11138, 
      #11516
      [skip ci]
      Marcus Efraimsson committed
    • Merge pull request #11599 from bergquist/rm_codecov · 2bfd6ab3
      removes codecov from frontend tests
      Carl Bergquist committed
    • Merge pull request #11550 from grafana/sql_ts_precision · ee303c03
      sql tsdb: fix precision and data type support for time columns
      Daniel Lee committed
    • Merge pull request #11579 from towolf/add-url-param-for-inactive-mode · 693ff1c0
      Add another URL param «inactive» which works like «kiosk» but with title
      Carl Bergquist committed
    • Merge pull request #11594 from xginn8/writable_plugins · a1402966
      Grafana-CLI: mention the plugins directory is not writable on failure
      Carl Bergquist committed
    • Merge pull request #11588 from mjtrangoni/fix-codespell-issues · 67daa9b0
      Fix codespell issues
      Daniel Lee committed
  2. 15 Apr, 2018 2 commits
  3. 14 Apr, 2018 5 commits
  4. 13 Apr, 2018 5 commits